Last modified: 2013-11-19 20:56:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46629, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44629 - Remove unnecessary entries from $wgMetaNamespaceTalk and $wgMetaNamespace
Remove unnecessary entries from $wgMetaNamespaceTalk and $wgMetaNamespace
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Tomasz W. Kozlowski
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-04 00:09 UTC by Sam Reed (reedy)
Modified: 2013-11-19 20:56 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2013-02-04 00:09:08 UTC
Where == str_replace( '$1', $wgMetaNamespace, $namespaceNames[NS_PROJECT_TALK] ) === $wgMetaNamespaceTalk, remove the entry in $wgMetaNamespaceTalk

In most/all cases, these should match, and hence, the explicit entry is unneeded.


Similar can be also said for $wgMetaNamespace, which if it's the same as $wgSitename, it isn't necessary.

/**
 * Name of the project namespace. If left set to false, $wgSitename will be
 * used instead.
 */
$wgMetaNamespace = false;
Comment 1 Dereckson 2013-02-04 11:42:09 UTC
Taking this bug.
Comment 2 Tomasz W. Kozlowski 2013-11-16 19:07:03 UTC
I'm re-taking the licked cookie and will submit a patch in a minute.
Comment 3 Gerrit Notification Bot 2013-11-16 19:07:22 UTC
Change 95796 had a related patch set uploaded by Odder:
(bug 44629) Clean up $wgSitename, $wgMetaNamespace etc.

https://gerrit.wikimedia.org/r/95796
Comment 4 Gerrit Notification Bot 2013-11-19 20:31:49 UTC
Change 95796 merged by jenkins-bot:
(bug 44629) Clean up $wgMetaNamespace, $wgMetaNamespaceTalk

https://gerrit.wikimedia.org/r/95796

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links