Last modified: 2013-03-06 17:20:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46636, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44636 - [statements-ui] Deleting a property leads to a JavaScript crash on items using that property
[statements-ui] Deleting a property leads to a JavaScript crash on items usin...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks: 44689
  Show dependency tree / graph
 
Reported: 2013-02-04 09:50 UTC by denny vrandecic
Modified: 2013-03-06 17:20 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description denny vrandecic 2013-02-04 09:50:42 UTC 
If an item has a statement using property P, and then the property gets deleted, viewing the page will lead to the JavaScript building to break down.

There might be further problems due to these steps.
Comment 1 Wikidata Bot 2013-02-04 13:01:34 UTC 
Change I7d0a971b: (bug 44636) added EntitySerializer option setIncludeValuesWithMissingReferences
Comment 2 tobias.gritschacher 2013-02-05 10:45:38 UTC 
This was fixed in production with the hotfix above, but it should be solved in a better way.
Comment 3 denny vrandecic 2013-02-07 16:48:39 UTC 

*** This bug has been marked as a duplicate of bug 44639 ***
Comment 4 Daniel A. R. Werner 2013-03-03 20:50:27 UTC 
This is not a duplicate of bug 44639. This is about a simple, first solution. bug 44639 is about advanced handling of the situation, like allowing to change the property to an existing one and allowing to remove that property.

Also, 44689 is not a duplicate, that's about being able to delete Statements using such deleted properties.

So the order of implementation would be 44636, 44689, 44639.

There has been some confusion around this, in our sprint planning we decided to pick up 44636, not the advanced handling suggested in 44639.
In the change set I am working on we will have 44636 and 44689 solved in the JavaScript UI.
Comment 5 Henning 2013-03-04 09:04:24 UTC 
Gerrit change #51954
Comment 6 abraham.taherivand 2013-03-06 17:20:32 UTC 
Verified in Wikidata demo sprint 34
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links