Last modified: 2013-02-13 16:12:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46641, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44641 - claimview JS error on save
claimview JS error on save
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-04 15:54 UTC by Aude
Modified: 2013-02-13 16:12 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2013-02-04 15:54:03 UTC
The way I tab through stuff and create statements, sometimes I accidentally hit "save" twice.  It says "Saving... Saving..."

I am now also getting a JS error, though not always.

mw.Api error:  createclaim-save-failed Object {error: Object} load.php:11129

Uncaught TypeError: Cannot call method 'enable' of undefined jquery.wikibase.claimview.js:428


In this line, the .data( 'wb-toolbar' ) returns undefined.

this.$toolbar.find( '.wb-ui-toolbar' ).data( 'wb-toolbar' ).enable();

I suppose people shouldn't hit save twice, so perhaps it's not critical it be fixed *right now* but would be good if the code handled this nicer without any errors.
Comment 1 Daniel A. R. Werner 2013-02-04 16:00:21 UTC
This is because each time hitting enter it will trigger an API call even though it did already. Not that critical since the save will still be performed, not even the UI gets broken by this.
Comment 2 Wikidata Bot 2013-02-04 16:03:21 UTC
Change Iafe8540f: (bug 44641) Preventing keydown event when disabled
Comment 3 abraham.taherivand 2013-02-13 16:12:05 UTC
Verified in Wikidata demo sprint 32

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links