Last modified: 2013-02-05 01:09:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46656, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44656 - File: pages for images broken on wmf9 (www.mediawiki.org) by TimedMediaHandler


Summary:	File: pages for images broken on wmf9 (www.mediawiki.org) by TimedMediaHandler

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	TimedMediaHandler (Other open bugs)
Version:	master
Hardware:	All All

Importance:	High critical (vote)
Target Milestone:	---
Assigned To:	Michael Dale

URL:	https://www.mediawiki.org/wiki/File:C...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-02-05 00:44 UTC by Brion Vibber
Modified:	2013-02-05 01:09 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2013-02-05 00:44:26 UTC

PHP fatal error in /usr/local/apache/common-local/php-1.21wmf9/extensions/TimedMediaHandler/TimedMediaHandler.hooks.php line 214:
Call to undefined method PNGHandler::isAudio()

Same on JPEG files, but it's JpegHandler::isAudio doesn't exist.

This probably shouldn't be called on files that don't belong to TimedMediaHandler... or it should be checking the handler class to make sure it's something it understands... or something.

Comment 1 Sam Reed (reedy) 2013-02-05 00:46:35 UTC

Also used on 209:

if( ( $mediaType == 'webm' || $mediaType == 'ogg' || $mediaType =='mp4' ) && ! $file->getHandler()->isAudio( $file ) ){

Comment 2 Sam Reed (reedy) 2013-02-05 00:54:40 UTC

https://gerrit.wikimedia.org/r/47542

Comment 3 Sam Reed (reedy) 2013-02-05 01:07:13 UTC

https://gerrit.wikimedia.org/r/#/c/47544

Comment 4 Brion Vibber 2013-02-05 01:09:03 UTC

Confirmed fixed. Thanks!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links