Last modified: 2014-02-12 23:35:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46657, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44657 - Change of IP block settings produces duplicate block
Change of IP block settings produces duplicate block
Status: NEW
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-05 01:25 UTC by Jasper Deng
Modified: 2014-02-12 23:35 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jasper Deng 2013-02-05 01:25:11 UTC
http://www.wikidata.org/w/index.php?title=Special:Log&page=User%3A211.206.122.150&type=block

In this block, Techman224 intended to change the settings of my original block, but instead created a duplicate block, as suggested by this log and Special:BlockList (not to mention pop-ups (i.e. via API)).

I have not seen this problem on any other wikis, but this problem has been present as early as December - http://www.wikidata.org/w/index.php?title=Special:Log&type=block&page=User:190.242.99.178 (where the latest log entry saying that I made a block was really me trying to change the block settings)
Comment 1 Techman224 2013-02-23 01:50:28 UTC
It look like the culprit is the time of the block. If you just change the settings, it changes just fine. See http://www.wikidata.org/w/index.php?title=Special:Log&page=User%3A186.233.104.1&type=block
Comment 2 Jasper Deng 2013-04-27 21:37:09 UTC
Can we please get this fixed? This problem has gone on for long enough.
Comment 3 Andre Klapper 2013-04-29 08:41:35 UTC
[Resetting severity to normal, see http://www.mediawiki.org/wiki/Bugzilla/Fields#Severity ]
Comment 4 Kunal Mehta (Legoktm) 2013-04-29 17:37:08 UTC
(In reply to comment #3)
> [Resetting severity to normal, see
> http://www.mediawiki.org/wiki/Bugzilla/Fields#Severity ]

I'm not sure how this isn't a "Major loss of function in an important area".

It's a major loss of function since every time two admins block the same vandal/spambot/etc one of them has to go back, manually undo two blocks, then re-block, and then revert/delete whatever the account did in the few sections it was unblocked for.

It's obviously an important area since we need to be able to stop vandalism and spammers and not have to redo a block that should have worked just fine in the first place.

More importantly this bug is important because no one else has reported it except on Wikidata. To the best of my knowledge, nothing in the Wikibase and related extensions should interfere with the blocking code, which means it might be a bigger problem.
Comment 5 MZMcBride 2013-04-30 02:39:08 UTC
I'm having a little difficulty following this bug. Are there actually duplicate blocks being saved to the database? Generally that should be prohibited. That is, there should only be one exact match for ipb_address (username or IP address) in ipblocks.

The underlying issue sounds something like "reblocks don't work properly with IP addresses," but it's difficult to say currently.
Comment 6 Jasper Deng 2013-04-30 03:53:02 UTC
http://www.wikidata.org/w/index.php?title=Special:Log&type=block&page=User:46.118.124.27

http://www.wikidata.org/w/index.php?title=Special:Log&type=block&page=User:27.159.235.177

http://www.wikidata.org/w/index.php?title=Special:Log&type=block&page=User:190.52.124.38

Just a few recent examples. In all these cases two, not just one, "BLOCKED"'s showed up in pop-ups when mousing over them, as well as two entries in Special:BlockList.
Comment 7 MZMcBride 2013-04-30 04:04:59 UTC
(In reply to comment #6)
> http://www.wikidata.org/w/index.php?title=Special:Log&type=block&page=User:46.118.124.27

From the Toolserver's wikidatawiki_p:

mysql> select * from logging_ts_alternative where log_namespace = 2 and log_title = '46.118.124.27';
+----------+----------+------------+----------------+----------+---------------+---------------+---------------+----------+----------------------------+-------------------------------------------------+-------------+
| log_id   | log_type | log_action | log_timestamp  | log_user | log_user_text | log_namespace | log_title     | log_page | log_comment                | log_params                                      | log_deleted |
+----------+----------+------------+----------------+----------+---------------+---------------+---------------+----------+----------------------------+-------------------------------------------------+-------------+
| 27988876 | block    | block      | 20130420233450 |     3724 | Jasper Deng   |             2 | 46.118.124.27 |        0 | spambot                    | 3 months
nocreate                               |           0 |
| 27989023 | block    | block      | 20130420233504 |     3724 | Jasper Deng   |             2 | 46.118.124.27 |        0 | spambot                    | Sat, 20 Jul 2013 23:34:50 GMT
anononly,nocreate |           0 |
| 27989395 | block    | unblock    | 20130420233544 |     3724 | Jasper Deng   |             2 | 46.118.124.27 |        0 | resolving double-block bug |                                                 |           0 |
| 27989469 | block    | unblock    | 20130420233552 |     3724 | Jasper Deng   |             2 | 46.118.124.27 |        0 | resolving double-block bug |                                                 |           0 |
| 27990113 | block    | block      | 20130420233655 |     3724 | Jasper Deng   |             2 | 46.118.124.27 |        0 | spambot                    | 3 months
anononly,nocreate                      |           0 |
+----------+----------+------------+----------------+----------+---------------+---------------+---------------+----------+----------------------------+-------------------------------------------------+-------------+
5 rows in set (0.00 sec)

All three examples from comment 6 have been "corrected." Are there any live/living examples of this problem? (I'll also note that a subsequent reblock of <https://www.wikidata.org/w/index.php?title=Special:Log&type=block&page=User:27.159.235.177> seemed to have worked just fine.)
Comment 8 MZMcBride 2013-04-30 04:09:34 UTC
http://p.defau.lt/?zwqWzA9XvamxrdVOZQlpGQ is vaguely more legible.

Perhaps this has to do with adjusting block settings? Does every example of this problem involve changing block settings?

And how are these blocks being made? Via the API via a user script? Via the block form? Some other way?
Comment 9 Jasper Deng 2013-04-30 04:12:29 UTC
The aforementioned blocks were made by hand using the on-wiki interface, and the problem always occurs for changes of block settings (not necessarily by the same admin - see previous comments).
Comment 10 MZMcBride 2013-04-30 04:15:37 UTC
From wikidatawiki_p:

mysql> select ipb_address, count(*) from ipblocks group by ipb_address having count(*) > 1 order by ipb_address;
+-----------------+----------+
| ipb_address     | count(*) |
+-----------------+----------+
|                 |        2 |
| 109.185.110.11  |        2 |
| 114.113.221.66  |        2 |
| 200.223.136.254 |        2 |
| 211.206.122.150 |        2 |
| 60.195.251.213  |        2 |
| 61.19.201.7     |        2 |
| 79.143.186.49   |        2 |
+-----------------+----------+
8 rows in set (0.01 sec)

enwiki_p has 114 rows for the same query.
Comment 11 Lydia Pintscher 2013-10-08 21:42:59 UTC
Does anyone have an idea what is special in Wikidata here that could cause this? Because I can't think of anything we're changing there.
Comment 12 Kunal Mehta (Legoktm) 2013-10-25 21:52:04 UTC
I was able to reproduce this on Uncyclopedia (1.21.1), so moving to MediaWiki component.

Myself and another sysop blocked at nearly the exact same time with different block settings, causing duplicate blocks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links