Last modified: 2013-05-08 12:20:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46661, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44661 - Current version being displayed as old revision
Current version being displayed as old revision
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest major (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-05 02:30 UTC by Yair Rand
Modified: 2013-05-08 12:20 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Yair Rand 2013-02-05 02:30:38 UTC 
When viewing an old revision of a page, all of the current properties are displayed, instead of whatever properties the item had during that revision.
Comment 1 Daniel A. R. Werner 2013-02-11 20:30:56 UTC 
This is because the entities serialized as 'wbUsedEntities' for the frontend are the current for some reason. Without JavaScript enabled, the right statements will be displayed.

I've already noticed a while ago while debugging that the whole EntityView logic is called twice, also EntityView::registerJsConfigVars() is running twice. Perhaps this is somehow related.
Comment 2 Daniel A. R. Werner 2013-02-11 20:40:24 UTC 
I was wrong about the code running twice, but the EntityView::registerJsConfigVars() is simply getting called with the wrong EntityContent (the current one) given.
Comment 3 Kunal Mehta (Legoktm) 2013-02-13 11:51:04 UTC 
For future reference, it was Gerrit change #48612 that fixed this.
Comment 4 abraham.taherivand 2013-02-13 16:11:40 UTC 
Verified in Wikidata demo sprint 32
Comment 5 tobias.gritschacher 2013-02-14 16:41:36 UTC 
This does not work when in diff view.
fix is here: https://gerrit.wikimedia.org/r/#/c/49068/
Comment 6 abraham.taherivand 2013-03-06 17:20:10 UTC 
Verified in Wikidata demo sprint 34
Comment 7 Matthew Flaschen 2013-04-18 01:50:57 UTC 
It seems like this has been reintroduced.  See https://www.wikidata.org/w/index.php?title=Q192925&oldid=6198828 .  It flashes the correct version (without labels).  Then it pulls in later statements through AJAX.
Comment 8 Gerrit Notification Bot 2013-04-25 15:40:43 UTC 
Related URL: https://gerrit.wikimedia.org/r/60868 (Gerrit Change I906214322ee6dcb32d397e110d2f097f098cc253)
Comment 9 Gerrit Notification Bot 2013-04-25 17:20:10 UTC 
Related URL: https://gerrit.wikimedia.org/r/60884 (Gerrit Change I906214322ee6dcb32d397e110d2f097f098cc253)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links