Last modified: 2013-04-22 16:15:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46734, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44734 - Add button actions for links
Add button actions for links
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Matthew Flaschen
: patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-07 04:15 UTC by Matthew Flaschen
Modified: 2013-04-22 16:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-02-07 04:15:25 UTC
Add button actions for internal and external links.

The description will also allow links, but sometimes it's important enough to put in the button.  Currently you have to hack it up with an onclick.  We'll probably do that internally, but for the user-facing API it should be easier.  How about:

{ action: "wikiLink", pageName: "Wikipedia:Tutorial", name: "Tutorial" }

{ action: "externalLink", url: "http://www.gutenberg.org/", namemsg: "guidedtour-tour-sometour-some-key" }

These will probably be a little different from the existing actions, in that I don't think they should use the Okay button.

I propose name and namemsg for the button text (for both), for consistency.
Comment 1 Matthew Flaschen 2013-02-14 04:18:20 UTC
Implemented in https://gerrit.wikimedia.org/r/#/c/49001/

I made a couple changes:

1. I used page instead of pageName for brevity.
2. They are actual links, not onclicks.  However, they still have the button class and look and act like buttons for the most part.  But e.g. they show the URL in the status bar (if applicable) and you can open in a new window/tab, like links.
Comment 2 Matthew Flaschen 2013-02-15 00:56:59 UTC
Merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links