Last modified: 2013-03-16 22:32:05 UTC
We seems to still have two conflicting sniffs regarding the space after a typecast. https://integration.mediawiki.org/ci/job/mediawiki-core-phpcs-HEAD/1373/console -------------------------------------------------------------------------------- FOUND 2 ERROR(S) AFFECTING 2 LINE(S) -------------------------------------------------------------------------------- 33 | ERROR | String concat is not required here; use a single string instead 37 | ERROR | String concat is not required here; use a single string instead -------------------------------------------------------------------------------- https://integration.mediawiki.org/ci/job/mediawiki-core-phpcs-HEAD/1375/console -------------------------------------------------------------------------------- FOUND 2 ERROR(S) AFFECTING 1 LINE(S) -------------------------------------------------------------------------------- 371 | ERROR | A cast statement must be followed by a single space 371 | ERROR | A cast statement must be followed by a single space -------------------------------------------------------------------------------- I have made phpcs to show the sniff code (-s option) with https://gerrit.wikimedia.org/r/47847
Test change: https://gerrit.wikimedia.org/r/47848 Turns out the codesniffer code base was not up to date... Need to fix that. /var/lib/tools/codesniffer is a submodule /var/lib/tools/mwcodesniffer is a local checkout which is manually updated.
