Last modified: 2013-03-16 22:29:53 UTC
The following two URLs contain patch sets where Jenkins is blocking proper backporting workflows: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:REL1_19,n,z https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:REL1_20,n,z Observed behaviour: Jenkins is rejecting patch sets that work as expected on 1.19 and 1.20 for various reasons. Observed are: * 10:22:05 Warning: Task "jshint" failed. Use --force to continue. (there were no changes to JavaScript in the patch set, so this indicates a major problem with the Jenkins tests for 1.19, essentially causing -2 reports on all patch sets, resulting in blocks for merging patch sets per documented processes). * 10:49:02 [exec] PHP_Invoker_TimeoutException: Execution aborted after 2 seconds (this is most probably the result of an updated setting in master, that was not backported to still supported branches, resulting in blocks for merging patch sets per documented processes). To merge, Jenkins' -2 has to be removed by a Gerrit admin and the patch set has to be merged without a successful audit trail, increasing risk of merging failing code. Expected behaviour: Jenkins shouldn't report fails on correct patch sets.
(In reply to comment #0) > To merge, Jenkins' -2 has to be removed by a Gerrit admin and the patch set > has > to be merged without a successful audit trail, increasing risk of merging > failing code. > Clarifying: this can be removed by anyone with the actual "Project Owner" rights on a repository. I'll be granting the more useful "Remove Reviewer" permission to the MW core group tomorrow.
Rephrased summary, REL1_19 does not pass jshint. Got to find a way to ignore that branch. Additionally REL1_20 can use a backport of https://gerrit.wikimedia.org/r/#/c/46503/ which raised the PHPUnit timeout.
The timeout bug was https://bugzilla.wikimedia.org/show_bug.cgi?id=42904 . I have backported it: REL1_19 https://gerrit.wikimedia.org/r/48408 REL1_20 https://gerrit.wikimedia.org/r/48407 Still have to ignore jshint in REL1_19
I have decorrelated the php lint and jshint Jenkins jobs: https://gerrit.wikimedia.org/r/#/c/48422/ (JJB) https://gerrit.wikimedia.org/r/#/c/48423/ (Zuul) Then made it so the mediawiki-core-jslint job is triggered for any branch NOT matching 'REL1_19' with https://gerrit.wikimedia.org/r/#/c/48427/. I slightly tweaked it later with https://gerrit.wikimedia.org/r/48431 . Testing the change in production gives out: Testing out a change made against REL1_19 shows no jslint job: Pipeline: check --------------- Project mediawiki/core change 48428,1 mediawiki-core-merge: None mediawiki-core-whitespaces: None (non-voting) mediawiki-core-phpcs-HEAD: None (non-voting) mediawiki-core-lint: None Pipeline: test -------------- Project mediawiki/core change 48428,1 mediawiki-core-merge: None mediawiki-core-phpcs-HEAD: None (non-voting) mediawiki-core-lint: None mediawiki-core-phpunit-databaseless: None mediawiki-core-install-sqlite: None mediawiki-core-phpunit-api: None mediawiki-core-phpunit-misc: None mediawiki-core-phpunit-parser: None Against REL1_20: Pipeline: check --------------- Project mediawiki/core change 48424,3 mediawiki-core-merge: None mediawiki-core-whitespaces: None (non-voting) mediawiki-core-phpcs-HEAD: None (non-voting) mediawiki-core-jslint: None (non-voting) mediawiki-core-lint: None Pipeline: test -------------- Project mediawiki/core change 48424,3 mediawiki-core-merge: SUCCESS mediawiki-core-phpcs-HEAD: None (non-voting) mediawiki-core-jslint: None (non-voting) mediawiki-core-lint: None mediawiki-core-phpunit-databaseless: None mediawiki-core-install-sqlite: None mediawiki-core-phpunit-api: None mediawiki-core-phpunit-misc: None mediawiki-core-phpunit-parser: None And on master branch: Pipeline: check --------------- Project mediawiki/core change 48027,7 mediawiki-core-merge: None mediawiki-core-whitespaces: None (non-voting) mediawiki-core-phpcs-HEAD: None (non-voting) mediawiki-core-jslint: None (non-voting) mediawiki-core-lint: None Pipeline: test -------------- Project mediawiki/core change 48027,7 mediawiki-core-merge: None mediawiki-core-phpcs-HEAD: None (non-voting) mediawiki-core-jslint: None (non-voting) mediawiki-core-lint: None mediawiki-core-phpunit-databaseless: None mediawiki-core-install-sqlite: None mediawiki-core-phpunit-api: None mediawiki-core-phpunit-misc: None mediawiki-core-phpunit-parser: None So we do not trigger JSHint anymore on REL1_19
Regenerated mediawiki-core-lint (to get rid of jshint). That seems to work fine for now :-]
