Last modified: 2013-03-16 22:32:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46848, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44848 - Patch sets in "translatewiki" repo are not merged


Summary:	Patch sets in "translatewiki" repo are not merged

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Continuous integration (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-02-10 11:27 UTC by Siebrand Mazeland
Modified:	2013-03-16 22:32 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2013-02-10 11:27:10 UTC

For example https://gerrit.wikimedia.org/r/#/c/47888/ was not merged where it was expected. Can you please look into this, Antoine?

Here's what I observe:
1. Patch set is submitted.
2. Jenkins added score (verified +1 if voting tests pass)
3. I add Code review +2.
4. Jenkins adds post code review score (verified +2 if voting tests pass)

Then when both are +2, I expect an automatic merge, but the status remains "Review in Progress". I've checked http://integration.mediawiki.org/zuul/status. No jobs are running.

Comment 1 Antoine "hashar" Musso (WMF) 2013-02-12 15:22:53 UTC

Yes I can look at it :-]

Looking on gallium:

 $ grep 47888 /var/log/zuulzuul.log.2013-02-10
 ...
 2013-02-10 11:23:08,740 ERROR zuul.IndependentPipelineManager: Reporting change <Change 0x7fa328654ed0 47888,4> received: error: (change 47888) not permitted to submit change

So Jenkins is not allowed to merge change there :-D

Comment 2 Antoine "hashar" Musso (WMF) 2013-02-12 15:27:48 UTC

Chad made it so JenkinsBot is now able to submit patches on translatewiki repository:

https://gerrit.wikimedia.org/r/gitweb?p=translatewiki.git;a=commitdiff;h=bafd2dd0bb44014c8de8f4b2afccbe4380fec939

Should be fine now.

Comment 3 Siebrand Mazeland 2013-02-12 15:56:17 UTC

(In reply to comment #2)
> Chad made it so JenkinsBot is now able to submit patches on translatewiki
> repository:
> 
> https://gerrit.wikimedia.org/r/gitweb?p=translatewiki.git;a=commitdiff;
> h=bafd2dd0bb44014c8de8f4b2afccbe4380fec939
> 
> Should be fine now.

Thanks Chad and Antoine!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links