Last modified: 2014-04-08 23:41:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46850, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44850 - files from UIDGenerator not deleted after test run
files from UIDGenerator not deleted after test run
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
1.21.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-10 15:00 UTC by db [inactive,noenotif]
Modified: 2014-04-08 23:41 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2013-02-10 15:00:09 UTC
Running phpunit leaves the following files in the tmp dir:

mw-UIDGenerator-UID-88
mw-UIDGenerator-UID-128
mw-UIDGenerator-UID-nodeid

Should be deleted automatically by UIDGenerator or the test
Comment 1 spage 2013-09-05 05:37:07 UTC
The same thing can happen after running maintenance/update.php, see bug 53791.
Comment 2 Bryan Davis 2014-03-27 20:43:16 UTC
Leaving the files on disk seems to be intended behavior of the UIDGenerator class. It uses these files to store counter state and as an inter-process lock when creating timestamp based UUID variants.

Adding a cleanup to the test should be possible.
Comment 3 Gerrit Notification Bot 2014-03-27 22:35:39 UTC
Change 121548 had a related patch set uploaded by BryanDavis:
Delete UIDGenerator cache files after unit tests

https://gerrit.wikimedia.org/r/121548
Comment 4 Gerrit Notification Bot 2014-04-07 23:09:14 UTC
Change 121548 merged by jenkins-bot:
Delete UIDGenerator cache files after unit tests

https://gerrit.wikimedia.org/r/121548

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links