Last modified: 2013-03-16 22:32:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46868, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44868 - Jenkins should update submodules recursively
Jenkins should update submodules recursively
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Unprioritized minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 43045
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-11 10:20 UTC by Ori Livneh
Modified: 2013-03-16 22:32 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2013-02-11 10:20:58 UTC
Jenkins (or Zuul, or whatever is handling Git submodules) should update submodules recursively by passing the '--recursive' flag to 'git submodule update'.
Comment 1 Matthew Flaschen 2013-02-11 14:59:01 UTC
Is this in regards to https://gerrit.wikimedia.org/r/#/c/48227/?

That was because the submodule change had to get merged first.  I don't think it's a bug.
Comment 2 Matthew Flaschen 2013-02-11 15:01:22 UTC
In other words, the change to mediawiki/extensions/GuidedTour/guiders had to get merged before the change in mediawiki/extensions/GuidedTour that required it.
Comment 3 Antoine "hashar" Musso (WMF) 2013-02-12 15:55:05 UTC
It seems the extension are fetched with their submodules. From the merging job https://integration.mediawiki.org/ci/job/mwext-GuidedTour-merge/77/console

10:15:25 stdout: Cloning into 'modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule'...
10:15:25 
10:15:25 stderr: fatal: reference is not a tree: 7d86ef3ac4896bcae553891d8c2faf02b643320a
10:15:25 Unable to checkout '7d86ef3ac4896bcae553891d8c2faf02b643320a' in submodule path 'modules/externals/mediawiki.libs.guiders/mediawiki.libs.guiders.submodule'

Which mean 7d86ef3ac4896bcae553891d8c2faf02b643320a was not in the submodule apparently (aka what Matthew explained just above).


For the record, the extension jobs are generated by Jenkins Job Builder. It apply the default settings 'use-zuul-for-mw-ext' which create the git part with submodule default setting (which is to fetch submodules).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links