Last modified: 2013-02-12 20:43:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46895, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44895 - Gerrit commit message font is too small


Summary:	Gerrit commit message font is too small

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Git/Gerrit (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Antoine "hashar" Musso (WMF)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-02-12 07:54 UTC by Antoine "hashar" Musso (WMF)
Modified:	2013-02-12 20:43 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2013-02-12 07:54:08 UTC

With Gerrit 2.5.1-1266-gcc231e1, the font size is smaller on the change page. The commit message text as a 11px size which is barely readable to me.  It used to be 12 px.

This is fixed by removing the font-size: 8pt rule in:

 .changeScreenDescription, .changeScreenDescription textarea {
   white-space: pre;
   font-family: monospace;
   font-size: 8t;
 }

The font-familly should really be:

 font-family: monospace, Courier;

That would fix the monospace font size.

Comment 1 Antoine "hashar" Musso (WMF) 2013-02-12 13:49:42 UTC

The hack I referenced above is only useful when no font-size is specified.

I have raised the font-size to 9pt with https://gerrit.wikimedia.org/r/48622

Comment 2 Chad H. 2013-02-12 14:45:15 UTC

Also pushed upstream: https://gerrit-review.googlesource.com/42260

Comment 3 Antoine "hashar" Musso (WMF) 2013-02-12 20:34:30 UTC

Change has been merged but does not seem to change the font size :/ Adding '!important' would work: https://gerrit.wikimedia.org/r/48732

Comment 4 Antoine "hashar" Musso (WMF) 2013-02-12 20:43:23 UTC

Merged by notpeter. We now have 9pt size to display commit messages.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links