Last modified: 2014-02-12 23:53:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46918, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 44918 - Gadgets now leak into mobile site
Gadgets now leak into mobile site
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Max Semenik
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-12 20:59 UTC by Jon
Modified: 2014-02-12 23:53 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2013-02-12 20:59:30 UTC 
I have a gadget enabled - mw:Reference Tooltips and this now seems to be running on the mobile site. There's no guarantee gadgets will work on mobile so we should probably disable these for the time being.

Luckily this won't effect the average visitor who will not have gadgets installed.
Comment 1 Jon 2013-02-27 19:30:44 UTC 
Can't seem to replicate this on a local version.. not sure why this is happening.
Comment 2 Max Semenik 2013-02-27 20:32:28 UTC 
(In reply to comment #0)
> Luckily this won't effect the average visitor who will not have gadgets
> installed.

Some gadgets are enabled by default.
Comment 4 Jon 2013-04-18 20:43:13 UTC 
Max lies (according to Maryana)
On Maryana's account I'm seeing the following gadgets load:

/w/index.php?title=MediaWiki:Gadget-popups.js&action=raw&ctype=text/javascript&532528798

/w/index.php?title=MediaWiki:Gadget-ReferenceTooltips.js&action=raw&ctype=text/javascript&508635914

https://en.m.wikipedia.org/w/index.php?title=MediaWiki:Gadget-edittop.js&action=raw&ctype=text/javascript&507509831

/w/index.php?title=MediaWiki:Gadget-metadata.js&action=raw&ctype=text/javascript&421724048

Several mobile exceptions thrown breaking her mobile experience.

Uncaught ReferenceError: hookEvent is not defined index.php:7671
Uncaught ReferenceError: importStylesheet is not defined index.php:19
Uncaught ReferenceError: getElementsByClassName is not defined
Comment 5 Michelle Grover 2013-04-24 01:29:54 UTC 
Change on 02/28 were abandoned
Comment 6 Gerrit Notification Bot 2013-05-01 18:23:45 UTC 
https://gerrit.wikimedia.org/r/61028 (Gerrit Change Ibc43852486041b940464310201654e4fa6c53c6e) | change APPROVED and MERGED [by jenkins-bot]
Comment 7 Jon 2013-05-08 14:12:03 UTC 
Did the core change get applied? gadgets still seem to be leaking..
Comment 8 Max Semenik 2013-05-09 17:29:24 UTC 
The Gadgets change https://gerrit.wikimedia.org/r/#/c/60954/ is not yet live:

maxsem@fenari:/h/w/c/php-1.22wmf3/extensions/Gadgets$ grep wfRunHooks Gadgets_body.php
maxsem@fenari:/h/w/c/php-1.22wmf3/extensions/Gadgets$
Comment 9 Arthur Richards 2013-05-09 18:23:29 UTC 
Interesting - the changeset is present (via git log) in the Gadgets extension submodule of the php-1.22wmf3 branch; I guess it just hasn't been updated/deployed in production.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links