Last modified: 2013-03-08 14:48:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46923, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 44923 - Chunked uploads returning continue instead of success


Summary:	Chunked uploads returning continue instead of success

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	API (Other open bugs)
Version:	1.21.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Brad Jorsch

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-02-13 01:56 UTC by Smallman
Modified:	2013-03-08 14:48 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Stash file in one post-Request (2.88 MB, text/plain) 2013-02-13 13:17 UTC, Smallman	Details
Stash file in one post-Response (543 bytes, text/plain) 2013-02-13 13:18 UTC, Smallman	Details
Add nothing to fully stashed file-Request (1.18 KB, text/plain) 2013-02-13 13:19 UTC, Smallman	Details
Add nothing to fully stashed file-Response (580 bytes, text/plain) 2013-02-13 13:19 UTC, Smallman	Details
Add an attachment (proposed patch, testcase, etc.)

Description Smallman 2013-02-13 01:56:07 UTC

When you upload the entire file in the first stash post, the upload status returned is 'Continue' instead of 'Success'

Also, if you post an empty chunk to a previously stashed file (that's fully uploaded), you get

{"servedby":"mw1142","error":{"code":"stashfailed","info":"Could not write to temporary file."}}

you should get a success.

Comment 1 Andre Klapper 2013-02-13 06:37:28 UTC

(In reply to comment #0)
> When you upload the entire file in the first stash post
> 
> Also, if you post an empty chunk to a previously stashed file (that's fully
> uploaded)

For both cases a small testcases is very welcome, so it's clear that everybody uses the same calls, parameters, values when trying to reproduce the problem.

Comment 2 Smallman 2013-02-13 13:17:39 UTC

Created attachment 11777 [details]
Stash file in one post-Request

Comment 3 Smallman 2013-02-13 13:18:13 UTC

Created attachment 11778 [details]
Stash file in one post-Response

Comment 4 Smallman 2013-02-13 13:19:10 UTC

Created attachment 11780 [details]
Add nothing to fully stashed file-Request

Comment 5 Smallman 2013-02-13 13:19:33 UTC

Created attachment 11781 [details]
Add nothing to fully stashed file-Response

Comment 6 Brad Jorsch 2013-02-27 01:16:25 UTC

Gerrit change #51066

Comment 7 Andre Klapper 2013-03-08 09:31:48 UTC

anomie: Your patch was merged, can this bug report be closed as FIXED?

Comment 8 Brad Jorsch 2013-03-08 14:48:44 UTC

Yes

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links