Last modified: 2014-02-12 23:40:03 UTC
The return key doesn't work with the "Add Reviewer" button in Gerrit, as far as I can tell. I find this behavior slightly infuriating.
WFM...
Timo reported upstream, added to see also urls.
https://code.google.com/p/gerrit/issues/detail?id=1784 seems to be about a different issue.
Indeed.
Removed. Needs reporting still.
Steps to add reviewer with enter key 1. Type in a partial name of a reviewer to add 2. Use arrow keys to navigate to the desired email 3. Press 'tab' key to select reviewer 4. Press 'enter' key -> This should successfully add the reviewer Steps that should add reviewer but do not work as expected. 1. Type in a partial name of a reviewer to add 2. Use mouse to select desired email 3. Press 'enter' key -> Does not add reviewer Can you add a reviewer using the first set of steps?
I could not add a reviewer using the second set of steps. The real root of the problem is in gwt. The gwt upstream fix is at https://gwt-review.googlesource.com/#/c/2100/ . The bug there is at https://code.google.com/p/google-web-toolkit/issues/detail?id=8051 . But as that fix needs time (and probably a push to the old svn repository there) to get accepted and to flow down to us through gerrit upstream, I pushed a fix to gerrit as well. Gerrit upstream is fixed by commit 882d3bc2cca0b1ebeca65276d163e14b2a32f39e at https://gerrit-review.googlesource.com/#/c/42891/ This commit fixes the problem also when trying to add a member to group.
I believe this is fixed now (via the gerrit fix, not gwt).
(In reply to comment #8) > I believe this is fixed now (via the gerrit fix, not gwt). Not working for me at <https://gerrit.wikimedia.org/r/12345>. To re-iterate, the bug here is that when the focus is on the "Add Reviewer" button, the return key on my keyboard cannot be used to "click" (or "submit") the button. I'll upload a screenshot as well.
Created attachment 12090 [details] Wikimedia Gerrit interface with the "Add Reviewer" button focused From this point in my workflow (with a valid reviewer in the text input field and the "Add Reviewer" button focused in my Web browser) I should be able to hit the return key on my keyboard to add the reviewer to the changeset. However, the hitting the return key has no effect at all. :-(
(In reply to comment #7) > The real root of the problem is in gwt. The gwt upstream fix is at > https://gwt-review.googlesource.com/#/c/2100/ > . The bug there is at > https://code.google.com/p/google-web-toolkit/issues/detail?id=8051 > . The gwt fix has been merged over the weekend https://code.google.com/p/google-web-toolkit/source/detail?r=11593
(In reply to comment #9) > Not working for me at <https://gerrit.wikimedia.org/r/12345>. We fixed adding reviewers according to the second set of steps in comment #6. It seems your problem is different after all, and your problem is with the first set of steps in comment #6. For at least Valerie and me, this first set of steps works as well. What OS, and browser are you using? Do you use any User-Javascript on the page? When the “Add Reviewer” is focused (on change 58060 -- test commit on a test repository), and I hit enter, a POST to https://gerrit.wikimedia.org/r/changes/58060/reviewers occurs with content {"reviewer":"QChris <christian@quelltextlich.at>"} Does your browser also attempt such a POST? If so, what is gerrit's response?
(In reply to comment #12) > What OS, and browser are you using? Do you use any User-Javascript on > the page? Google Chrome, OS X 10.8.3, no user JavaScript. > When the “Add Reviewer” is focused (on change 58060 -- test commit on > a test repository), and I hit enter, a POST to > https://gerrit.wikimedia.org/r/changes/58060/reviewers > occurs with content > {"reviewer":"QChris <christian@quelltextlich.at>"} > > Does your browser also attempt such a POST? If so, what is gerrit's > response? I don't believe the browser does anything when I hit the return key currently. Every standard HTML input form on the Internet works. Something about Gerrit's architecture causes Gerrit to not act like every other HTML input form (where tabbing to a submit button and hitting the return key works).
By the way, the "Publish Comments" button works just fine on Gerrit using the return key. It's something to do with the "Add Reviewer" button specifically it seems. I was starting to suspect that perhaps this particular button has been intentionally disabled, but I have no real basis for this claim (other than the fact that the return key seemingly can't be used to submit the input/press the button).
