Last modified: 2014-02-12 23:32:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T46952, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 44952 - XCache return values are not handled correctly
XCache return values are not handled correctly
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-13 15:22 UTC by Mark A. Hershberger
Modified: 2014-02-12 23:32 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2013-02-13 15:22:46 UTC
From support desk: https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Caching_issue_makes_MediaWiki_painfully_slow/reply_(4)

This was caused by mw bug (or bug in some xcache version).

xcache_get returns NULL if nothing can be acquired from cache, but mw waits for false.

if ( $this->get( $key ) === false ) {

at line 147 of includes/objectcache/BagOStuff.php, while xcache will return NULL in this case, so

for ( $i = 0; $i < MSG_WAIT_TIMEOUT && !$this->mMemc->add( $lockKey, 1, MSG_LOCK_TIMEOUT ); $i++ ) {

at line 581 of includes/cache/MessageCache.php will get timeout in 10 seconds (default value).

mediawiki 1.20.2, xcache v3.0.1

I'll report this to bugzilla if not forget.
Comment 1 Roland Hieber 2013-02-24 13:00:06 UTC
There is a fix in the development version, apparently:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=commit;h=0072e0efeb8591a7761b3d573f8b71ef97fb96ec

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links