Last modified: 2013-07-25 07:06:16 UTC
Looks like the API that gerrit-wm gets its data from has changed in the latest Gerrit update. The Path set prefix is now considered part of the comment, so when the bot trims the first line, it now gets the Patch Set prefix instead of the real first line of the comment. <gerrit-wm> New review: Krinkle; "Patch Set 6:" [integration/jenkins-job-builder] (master) - https://gerrit.wikimedia.org/r/44836
While we're at it, lets rewrite it to use the rest api.
btw, this also means we're getting notifications in IRC for "(no comment)" actions (which we previously disabled). Is this being worked on already? If not, maybe point out where this logic is. Perhaps someone can take it on.
Thanks for filing this bug, Krinkle.
(In reply to comment #2) > Is this being worked on already? If not, maybe point out where this logic is. > Perhaps someone can take it on. No, I hadn't started it yet. It's all in the puppet repo, the hooks can be found in files/gerrit/hooks/*
Note that Zuul look at 'recheck' comments to retrigger a check on the change. The regex had to be updated: - comment_filter: (?i)^\s*recheck\.?\s*$ + comment_filter: (?im)^Patch Set \d+:\n\n\s*recheck\.?\s*$ References: https://gerrit.wikimedia.org/r/#/c/49245/ https://gerrit.wikimedia.org/r/#/c/49249/
Being handled in Gerrit change #50041.
Zuul does look for a comment like 'recheck'. Some regex need to be updated in zuul-config : https://gerrit.wikimedia.org/r/50121
This is merged and live.
Zuul change deployed as well.
Great!
