Last modified: 2013-07-04 10:35:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47026, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45026 - http://parsoid.wmflabs.org/en/Single_Ladies_%28Put_a_Ring_on_It%29 slow and broken rendering of {{listen}} template
http://parsoid.wmflabs.org/en/Single_Ladies_%28Put_a_Ring_on_It%29 slow and b...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
: performance, testme
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-14 22:18 UTC by Gabriel Wicke
Modified: 2013-07-04 10:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-02-14 22:18:44 UTC
This page currently takes ~100 seconds to render in Parsoid, which might be related to the high number of citations and API request timeouts.

The {{listen}} template also contains a broken div rendered as plain text.
Comment 1 C. Scott Ananian 2013-02-14 23:14:03 UTC
Just expanding '{{Listen}}' with http://parsoid.wmflabs.org/_wikitext/ shows the broken <div>.
Comment 2 C. Scott Ananian 2013-02-14 23:15:55 UTC
This might be related (or it may just be that my install is broken, you should attempt to reproduce this on a known-good setup):

$ echo "{{Listen}}" | node tests/parse.js 
ERROR in Main page:
TypeError: Cannot read property 'constructor' of undefined
    at AsyncTokenTransformManager.transformTokens (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/mediawiki.TokenTransformManager.js:478:13)
    at AsyncTokenTransformManager.onChunk (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/mediawiki.TokenTransformManager.js:352:17)
    at SyncTokenTransformManager.EventEmitter.emit (events.js:96:17)
    at SyncTokenTransformManager.onChunk (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/mediawiki.TokenTransformManager.js:857:7)
    at SyncTokenTransformManager.process (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/mediawiki.TokenTransformManager.js:757:7)
    at ParserPipeline.process (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/mediawiki.parser.js:359:21)
    at Frame.expand (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/mediawiki.TokenTransformManager.js:1333:13)
    at AttributeTransformManager.process (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/mediawiki.TokenTransformManager.js:936:16)
    at AttributeExpander.onToken (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/ext.core.AttributeExpander.js:49:7)
    at AsyncTokenTransformManager.transformTokens (/home/cananian/Projects/OLPC/Narrative/mediawiki/Parsoid/js/lib/mediawiki.TokenTransformManager.js:524:17)
Comment 3 ssastry 2013-02-14 23:20:17 UTC
Looks like this template parse broke in git SHA 555ec42.  Will investigate.  Thanks Scott.
Comment 4 Gabriel Wicke 2013-02-15 00:39:09 UTC
The crasher was fixed in 9388314d8ec9 (now merged).
Comment 5 ssastry 2013-02-25 23:12:00 UTC
The parse failure is related to this unclosed div-attribute in http://en.wikipedia.org/w/index.php?title=Template:listen/core&action=edit

Note the missing " on the 3rd line.  So, Parsoid tokenizer doesn't yet handle this.  I guess we can make Parsoid more robust, but maybe also fix the template?  

See https://bugzilla.wikimedia.org/show_bug.cgi?id=45341 for another example of fixing a template was considered the right fix.
Comment 6 ssastry 2013-02-26 23:33:09 UTC
Submitted an edit request at:

http://en.wikipedia.org/wiki/Template_talk:Listen#Missing_quote_in_template_source

Meanwhile will add a new ticket to be more liberal while parsing.
Comment 7 ssastry 2013-02-26 23:35:14 UTC
And looks like it's been fixed.
Comment 8 ssastry 2013-02-26 23:55:02 UTC
It also seems to parse reasonably quickly (30-35 secs on my laptop).  So, resolving this.  Reopen if there is any other related issue.
Comment 9 Andre Klapper 2013-07-04 10:35:06 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links