Last modified: 2013-06-30 19:59:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47038, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45038 - gerrit: swap CR / V columns in dashboard view
gerrit: swap CR / V columns in dashboard view
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 47661 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-15 09:32 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-06-30 19:59 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-02-15 09:32:44 UTC
With the recent Gerrit upgrade, the dashboard shows the Code-review columns first then the Verified one.  That use to be Verified -> Code-Review.

It is not really an issue until someone browse different Gerrit instances using the V->CR order.

Examples instances having V->CR:

Android https://android-review.googlesource.com/
Openstack https://review.openstack.org/


Not a high priority, just something that would be nice to restore.
Comment 1 Chad H. 2013-02-19 16:40:34 UTC
gerrit> select * from approval_categories;
 name        | abbreviated_name | position | function_name | copy_min_score | category_id
 ------------+------------------+----------+---------------+----------------+------------
 Code Review | R                | 1        | MaxWithBlock  | Y              | CRVW
 Verified    | V                | 0        | MaxWithBlock  | N              | VRIF
(2 rows; 1 ms)

They should be in that order (compare it to an individual change's review table). It seems as though the results are not respecting the position...weird that it's working on android-review (openstack's still on 2.4.2).
Comment 2 Chad H. 2013-04-25 18:20:53 UTC
*** Bug 47661 has been marked as a duplicate of this bug. ***
Comment 3 Gerrit Notification Bot 2013-05-19 15:47:48 UTC
Related URL: https://gerrit.wikimedia.org/r/64524 (Gerrit Change I25b442241f99e1674c32934ce0b2c9cabb910601)
Comment 4 christian 2013-05-19 16:03:17 UTC
It seems that

  https://android-review.googlesource.com/

has also had its gerrit upgraded and it now also uses CR/V in the change table

  https://android-review.googlesource.com/#/q/status:open,n,z

and V/CR on the changes themselves

  https://android-review.googlesource.com/#/c/44972/

. As consistency between gerrits hosted elsewhere seems less of an issue,
the change from comment #3 at least makes our column order consistent.
Labels get sorted alphabetically on both the change table and changes themselves.
Comment 5 christian 2013-06-29 13:08:28 UTC
With our gerrit upgrade on 2013-06-27 we got consistency of the columns back.

They're now ordered alphabetically on both change screens and lists of changes.
Comment 6 Antoine "hashar" Musso (WMF) 2013-06-30 19:59:22 UTC
swapped but consistent indeed :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links