Last modified: 2013-03-28 22:51:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47060, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45060 - Filename should not be /private/wmf/secret.yml
Filename should not be /private/wmf/secret.yml
Status: VERIFIED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Željko Filipin
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-15 23:38 UTC by Matthew Flaschen
Modified: 2013-03-28 22:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-02-15 23:38:26 UTC
/private does not exist under the [[Filename Hierarchy Standard]].

More pragmatically, just creating the root /private directory will require root privileges on many systems, and it clutters the root of the filesystem.

It should probably be in the same directory as the git checkout, but not actually tracked by git.

Alternative a sub-directory of /etc would work.
Comment 1 Željko Filipin 2013-02-19 17:44:13 UTC
We have used /private/wmf/ because that is where Cloudbees (hosted Jenkins that we use) expects files with credentials. I will update the code too look for secret.yml in ./config/ first (next to config.yml and cucumber.yml), then in  /private/wmf/ and if it does not find it then raise exception saying secret.yml is required for tests to run. Does that sound good?
Comment 2 Matthew Flaschen 2013-02-19 21:32:44 UTC
That works, though as I said on the other bug, some of the tests should be runnable without a secret.
Comment 3 Željko Filipin 2013-02-21 00:53:52 UTC
I will implement the check if the file is in config folder, then investigate how to make it optional. Sounds good?
Comment 4 Matthew Flaschen 2013-02-21 04:45:41 UTC
Yep.  Thanks for the quick response.
Comment 5 Željko Filipin 2013-03-27 11:39:36 UTC
Apologies for the really late bug fix: https://gerrit.wikimedia.org/r/#/c/56128/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links