Last modified: 2013-11-05 18:29:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47072, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45072 - JobQueueGroup::getQueuesWithJobs used one query per type
JobQueueGroup::getQueuesWithJobs used one query per type
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JobQueue (Other open bugs)
1.21.x
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-16 11:07 UTC by db [inactive,noenotif]
Modified: 2013-11-05 18:29 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2013-02-16 11:07:51 UTC
Looking at the log gives many queries against the job table to determine, if some jobs exist there. The calls are out of JobQueueGroup::getQueuesWithJobs or JobQueueGroup::getDefaultQueuesWithJobs to JobQueue::isEmpty

Maybe this can be optimized by using a DISTINCT query? That sounds faster, than, by default, 9 queries.
Comment 1 Gerrit Notification Bot 2013-07-04 07:26:17 UTC
Change 71966 had a related patch set uploaded by Aaron Schulz:
jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs()

https://gerrit.wikimedia.org/r/71966
Comment 2 Gerrit Notification Bot 2013-10-01 03:23:57 UTC
Change 71966 merged by jenkins-bot:
jobqueue: improved performance of JobQueueGroup::getQueuesWithJobs()

https://gerrit.wikimedia.org/r/71966

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links