Last modified: 2013-04-22 16:16:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47130, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45130 - new meta=siteinfo&siprop=protocols does not work correct
new meta=siteinfo&siprop=protocols does not work correct
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.21.x
All All
: Unprioritized major (vote)
: ---
Assigned To: Alex Monk
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-18 20:24 UTC by Umherirrender
Modified: 2013-04-22 16:16 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Umherirrender 2013-02-18 20:24:30 UTC
Gerrit change #49179 adds siprop=protocols.

But that gives for
http://test2.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=protocols

<s<a href="pan">pan</a> style="color:blue;">&lt;?xml version=&quot;1.0&quot;?&gt;</s<a href="pan">pan</a>>
<s<a href="pan">pan</a> style="color:blue;">&lt;a<a href="pi">pi</a>&gt;</s<a href="pan">pan</a>>
  <s<a href="pan">pan</a> style="color:blue;">&lt;query&gt;</s<a href="pan">pan</a>>
    <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="protocols">protocols</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="http://">http://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="https://">https://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="ftp://">ftp://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="irc://">irc://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="ircs://">ircs://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="gopher://">gopher://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="telnet://">telnet://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="nntp://">nntp://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="worldwind://">worldwind://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="mailto:">mailto:</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="news:">news:</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="svn://">svn://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="git://">git://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>><a href="mms://">mms://</a><s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
      <s<a href="pan">pan</a> style="color:blue;">&lt;<a href="p">p</a>&gt;</s<a href="pan">pan</a>>//<s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="p">p</a>&gt;</s<a href="pan">pan</a>>
    <s<a href="pan">pan</a> style="color:blue;">&lt;/<a href="protocols">protocols</a>&gt;</s<a href="pan">pan</a>>
  <s<a href="pan">pan</a> style="color:blue;">&lt;/query&gt;</s<a href="pan">pan</a>>
<s<a href="pan">pan</a> style="color:blue;">&lt;/a<a href="pi">pi</a>&gt;</s<a href="pan">pan</a>>

This is happen, because ApiResult::setIndexedTagName is called and added the 'p' as protocol to $wgUrlProtocols, should be done on a copy of the array, not on the global direct.
Comment 1 Alex Monk 2013-02-18 20:58:47 UTC
Gerrit change #49744
Comment 2 Alex Monk 2013-02-18 21:15:32 UTC
Approved by Anomie.
Comment 3 Alex Monk 2013-02-19 01:15:43 UTC
Cherry-picked to 1.21wmf10 in Gerrit change #49795, deployed by Anomie.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links