Last modified: 2013-04-04 06:52:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47175, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45175 - VisualEditor: Fix dependency issues between ve.js and ve.init.platform
VisualEditor: Fix dependency issues between ve.js and ve.init.platform
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-04-15
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-19 22:05 UTC by Roan Kattouw
Modified: 2013-04-04 06:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-02-19 22:05:08 UTC
In ve.js, function ve.msg:
// TODO: Fix dependency issues between ve.js and ve.init.platform

I don't know how this should be fixed exactly, Timo put this comment in in 407de829dd8f2e51c22a8378dc70c79fc6645d1e . I did notice that running the VE tests from Special:JavaScriptTest doesn't work because ve.msg() errors out with 've.init.platform' undefined.
Comment 1 Krinkle 2013-02-19 22:29:03 UTC
(In reply to comment #0)
> In ve.js, function ve.msg:
> // TODO: Fix dependency issues between ve.js and ve.init.platform
> 
> I don't know how this should be fixed exactly, Timo put this comment in in
> 407de829dd8f2e51c22a8378dc70c79fc6645d1e . I did notice that running the VE
> tests from Special:JavaScriptTest doesn't work because ve.msg() errors out
> with
> 've.init.platform' undefined.

Indeed, that's the reason why. They sometimes fail, and sometimes work.

It appears to be a race-condition and/or absent dependency that should be fixed or lazy-loaded or something else to make sure one has the other.
Comment 2 Krinkle 2013-04-03 03:19:27 UTC
This is currently blocking us from enabling QUnit for extension VisualEditor as the race-condition is happening consistently in Chrome, Safari and PhantomJS.

I tracked it down to the calls to ve.msg from the global scope, such as:


@@ ve.ce.Surface.static.$phantomTemplate = $ (.. ) .attr( {
		'title': ve.msg( 'visualeditor-aliennode-tooltip' ),
Comment 3 Krinkle 2013-04-03 03:48:12 UTC
Change-Id: I47d7d92495974572194700c98a219d22ecbfaf4b

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links