Last modified: 2014-03-11 02:04:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47183, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45183 - VisualEditor: newFromWrap() should perform validation
VisualEditor: newFromWrap() should perform validation
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-20 02:01 UTC by Roan Kattouw
Modified: 2014-03-11 02:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-02-20 02:01:20 UTC 
ve.dm.Transaction.newFromWrap() currently doesn't check that the transaction it generates will be valid. That is, it will ensure that things are unwrapped correctly, but it doesn't check that the result doesn't end up violating parent/child restrictions.

It's not entirely clear to me whether we should try to rectify that or throw an exception, but either of those is better than generating a transaction that, when applied, will make the document nonconformant.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links