Last modified: 2013-04-16 23:24:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47239, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45239 - Load data-parsoid into data.parsoid using loadDataAttrib once and save it back using saveDataAttribs
Load data-parsoid into data.parsoid using loadDataAttrib once and save it bac...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
DOM (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Mark Holmquist
: performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-21 18:40 UTC by Gabriel Wicke
Modified: 2013-04-16 23:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gabriel Wicke 2013-02-21 18:40:41 UTC
We are performing a lot of work on data-parsoid information in various DOM postprocessor passes. This currently involves a lot of repeated decoding and re-encoding of the data-parsoid attribute.

Instead, we should load data-parsoid into the data.parsoid member once when starting the DOM postprocessing using loadDataAttrib (or the loadDataParsoid wrapper) in DOMUtils. the postprocessor code would then work directly on the JS data.parsoid object. This should clean up the code and improve performance.

Before serializing the DOM out, the JS objects need to be serialized back to data-parsoid with DOMUtils.saveDataAttribs.
Comment 1 ssastry 2013-04-16 23:24:43 UTC
Mark Holmquist has implemented this and this has been merged.

https://gerrit.wikimedia.org/r/#/c/57219/
https://gerrit.wikimedia.org/r/#/c/57648/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links