Last modified: 2013-05-21 21:24:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47241, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45241 - As OpenID server, allow wiki/User:Username OpenIDs also when the userpage has no content
As OpenID server, allow wiki/User:Username OpenIDs also when the userpage has...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OpenID (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: T. Gries
:
Depends on: 45255
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-21 19:11 UTC by T. Gries
Modified: 2013-05-21 21:24 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2013-02-21 19:11:41 UTC
As OpenID server, allow wiki/User:Username OpenIDs also when the userpage has no content.

Currently, a user page must exist to make it working as OpenID Url.

The change request aims to drop this necessity.
Comment 1 T. Gries 2013-02-21 19:16:03 UTC
The problem is, that non-existing user pages give

ERROR 404: Not Found.

on the consumer.
Comment 2 T. Gries 2013-02-21 23:13:48 UTC
fixed in https://gerrit.wikimedia.org/r/#/c/50305/
Comment 3 MZMcBride 2013-03-23 19:11:20 UTC
(In reply to comment #2)
> fixed in https://gerrit.wikimedia.org/r/#/c/50305/

Apparent regression: bug 46491. I'm not sure the approach taken there was best.
Comment 4 T. Gries 2013-03-23 20:18:20 UTC
The other bug is apparently about non-existent User/***SUB***pages. These can if you like anewered with a 404.

Empty Userpages for existent users must be responded with a 200 to allow the use of the page as OpenID Identity.

In case of doubts, pls. discuss with Ryan.
Comment 5 MZMcBride 2013-03-24 15:27:16 UTC
(In reply to comment #4)
> The other bug is apparently about non-existent User/***SUB***pages. These can
> if you like anewered with a 404.

Right. But it's a regression caused by the resolution of this bug.

> Empty Userpages for existent users must be responded with a 200 to allow the
> use of the page as OpenID Identity.

As I understand it, this is true iff the identity URL is /wiki/User:Foo. I'm not sure the implementation here is a great re-use of this URL scheme, as I noted on the Gerrit changeset.
Comment 6 Krinkle 2013-05-21 20:53:17 UTC
This change has been reverted through bug 46491 and I900f1542b077b569ed.

I tend to agree that the User page should not be HTTP 200 OK if the wiki page does not exist. Should probably use some other url to identify the user (instead of re-using the user wikipage) or (if possible) expose some kind of meta data on the 404 page that makes OpenID look at the right URL.
Comment 7 Ryan Lane 2013-05-21 21:15:52 UTC
It was not reverted. The change you linked makes user subpages return 404, not user pages. Non-existing user pages will still return 200.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links