Last modified: 2014-03-11 02:05:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47291, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45291 - VisualEditor: Kill global functions in test suites
VisualEditor: Kill global functions in test suites
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-22 20:48 UTC by Roan Kattouw
Modified: 2014-03-11 02:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2013-02-22 20:48:56 UTC 
Functions like runConverterTests() and what not are often global functions in the test file. These should be un-global-ified somehow.
Comment 1 Krinkle 2013-05-21 14:10:00 UTC 
I can't find these any more. Resolved?
Comment 2 Krinkle 2013-05-21 16:11:07 UTC 
Found a few:

- ve.dm.ModelRegistry.test
* function checkForPickMe

- ve.dm.Transaction.test
* function runBuilderTests
* function runConstructorTests
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links