Last modified: 2013-04-22 16:15:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47405, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45405 - Issues with manual thumbnails
Issues with manual thumbnails
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.21.x
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-26 01:14 UTC by C. Scott Ananian
Modified: 2013-04-22 16:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description C. Scott Ananian 2013-02-26 01:14:11 UTC
The output for [[Image:Bad.jpg|thumb=Foobar.jpg|Title]] is:

<div class="thumb tright"><div class="thumbinner" style="width:1943px;"><a href="/wiki/File:Foobar.jpg" class="image"><img alt="" src="http://example.com/images/3/3a/Foobar.jpg" width="1941" height="220" class="thumbimage" srcset="http://example.com/images/0/09/Bad.jpg 1.5x, http://example.com/images/0/09/Bad.jpg 2x" /></a>  <div class="thumbcaption"><div class="magnify"><a href="/wiki/File:Bad.jpg" class="internal" title="Enlarge"><img src="/skins/common/images/magnify-clip.png" width="15" height="11" alt="" /></a></div>Title</div></div></div>

This has several problems:

1) This output is from parserTests, where Bad is supposed to be a blacklisted image; that doesn't seem to be getting caught.
2) presumably the <a href> link should be to the image (ie, Bad.jpg) not to the thumbnail
3) the src and srcset are inconsistent.  (Using the thumbnail for src but the original image for srcset.)
Comment 1 C. Scott Ananian 2013-02-26 01:18:41 UTC
Related parsoid issue: https://gerrit.wikimedia.org/r/50318
Comment 2 C. Scott Ananian 2013-02-26 01:42:14 UTC
The blacklist issue (#1 above) is explained by https://www.mediawiki.org/wiki/Special:Code/MediaWiki/100932 -- apparently we can't test the blacklist from parserTests?

The other two issues seem to still be legit.
Comment 3 C. Scott Ananian 2013-02-27 00:18:34 UTC
See https://gerrit.wikimedia.org/r/51075
Comment 4 Andre Klapper 2013-02-27 19:07:31 UTC
Thanks for the report and your patch!
Comment 5 db [inactive,noenotif] 2013-03-16 18:24:56 UTC
maybe related: bug 34194
Comment 6 Brion Vibber 2013-03-29 18:24:37 UTC
https://gerrit.wikimedia.org/r/51075 merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links