Last modified: 2013-04-22 16:15:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47477, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45477 - Load GettingStarted CSS if JS is disabled
Load GettingStarted CSS if JS is disabled
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GettingStarted (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Matthew Flaschen
: patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-27 05:32 UTC by Matthew Flaschen
Modified: 2013-04-22 16:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2013-02-27 05:32:11 UTC 
The page itself (without logging, guided tours, etc.) should be able to load fine without JS.

It's just the ResourceLoader combined package causing the CSS not to load which in this case severely hurts the appearance.
Comment 1 Steven Walling 2013-02-27 18:52:19 UTC 
How much if this problem is more to do with the way ResourceLoader works, versus being specific to GettingStarted? I agree there is no good reason why CSS should break if you lack JS, but last time we talked it was suggested that this was outside the scope of just GettingStarted to fix.
Comment 2 Matthew Flaschen 2013-02-27 21:30:01 UTC 
I didn't have as good an understanding of how to do this before.

Fixed in https://gerrit.wikimedia.org/r/#/c/51274/, on toro (http://toro.wmflabs.org/wiki/Special:GettingStarted) and awaiting code review.
Comment 3 Steven Walling 2013-02-27 21:33:08 UTC 
(In reply to comment #2)
> I didn't have as good an understanding of how to do this before.
> 
> Fixed in https://gerrit.wikimedia.org/r/#/c/51274/, on toro
> (http://toro.wmflabs.org/wiki/Special:GettingStarted) and awaiting code
> review.

LGTM in FF with JS disabled.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links