Last modified: 2013-03-06 11:41:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47493, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 45493 - [TUX] Do not consider empty string to mark a translation as "unsaved"


Summary:	[TUX] Do not consider empty string to mark a translation as "unsaved"

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Translate (Other open bugs)
Version:	master
Hardware:	All All

Importance:	High minor (vote)
Target Milestone:	---
Assigned To:	Bharat Kumar Jonnalagadda

URL:
Whiteboard:
Keywords:	i18n

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-02-27 15:57 UTC by Pau Giner
Modified:	2013-03-06 11:41 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pau Giner 2013-02-27 15:57:09 UTC

When the user edits an untranslated message by adding and removing some text. The translation is empty but by closing the editor, the message is marked as "unsaved" leading to the wrong impression that there are unsaved changes.

Comment 1 Bharat Kumar Jonnalagadda 2013-03-02 10:46:32 UTC

Couldnot repro. Can you provide a screenshot or more repro steps.

Comment 2 Niklas Laxström 2013-03-04 12:29:09 UTC

1) Open https://translatewiki.net/w/i.php?title=Special:Translate&group=out-freecol&language=fi&filter=%21translated&action=translate
2) Click the first message
3) Type "a"
4) Remove "a"
5) Close the editor or click "Skip to next"

Comment 3 Bharat Kumar Jonnalagadda 2013-03-04 12:56:56 UTC

Hmm. Then what is the actual case where we show the status as "unsaved". I am thinking only those two scenarios.

Comment 4 Santhosh Thottingal 2013-03-04 14:47:45 UTC

(In reply to comment #3)
> Hmm. Then what is the actual case where we show the status as "unsaved". I am
> thinking only those two scenarios.

We need to show "unsaved" if the original translation is not equal to the translation just before closing or skipping. ie, you have a valid change that is not saved yet.

Comment 5 Santhosh Thottingal 2013-03-04 17:07:03 UTC

Patch in gerrit I59b5b4d1811cf435c72d7796eff6fa6222fb77e1

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links