Last modified: 2013-04-11 10:32:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47520, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45520 - Disable tests on fundraising/1.20 branch of core
Disable tests on fundraising/1.20 branch of core
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-27 21:29 UTC by Peter Gehres
Modified: 2013-04-11 10:32 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Peter Gehres 2013-02-27 21:29:38 UTC
For now, fundraising/1.20 does not pass the tests and gerrit/jenkins doesn't merge changes.  The tests that fail are unrelated to the changes we make. Hopefully our upgrade to 1.21 in the near future will resolve this, but for now it is very annoying.
Comment 1 Antoine "hashar" Musso (WMF) 2013-02-28 01:16:14 UTC
So turns out that branch does not pass jshint tests. We could probably make them non-voting.
Two tests are failing due to deprecations notice:

1) RevisionStorageTest::testRevText

Use of Revision::revText was deprecated in MediaWiki 1.17. [Called from RevisionStorageTest::testRevText in /var/lib/jenkins/jobs/mediawiki-core-phpunit-misc/workspace/tests/phpunit/includes/RevisionStorageTest.php at line 219


2) WikiPageTest::testPreSaveTransform

Use of WikiPage::preSaveTransform was deprecated in MediaWiki 1.19. [Called from WikiPageTest::testPreSaveTransform in /var/lib/jenkins/jobs/mediawiki-core-phpunit-misc/workspace/tests/phpunit/includes/WikiPageTest.php at line 776]
Comment 2 Antoine "hashar" Musso (WMF) 2013-02-28 01:28:57 UTC
The attempt to fix the unit tests is in change https://gerrit.wikimedia.org/r/#/c/51321/
Comment 3 Peter Gehres 2013-02-28 01:34:28 UTC
Looks like it failed again on 
https://integration.mediawiki.org/ci/job/mediawiki-core-phpunit-databaseless/3532/console
Comment 4 Matt Walker 2013-03-01 00:39:53 UTC
So -- what's wrong with just disabling them altogether? It's really rather irritating. I mean -- I appreciate the concept of code review; but let's not do it on our release branch.
Comment 5 Krinkle 2013-04-09 20:12:28 UTC
There is nothing to enable or disable because fundraising isn't using Gerrit. As such there are never any events dispatched to Zuul and by extend, Jenkins.

The only change ever to be submitted to Gerrit for fundraising/* was the change Hashar linked earlier.
Comment 6 Gerrit Notification Bot 2013-04-11 10:32:33 UTC
https://gerrit.wikimedia.org/r/51321 (Gerrit Change I5d0b03385de42396d8f819dafe4da28fa1ba1c23) | change ABANDONED [by Hashar]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links