Last modified: 2013-03-04 22:14:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47586, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45586 - Hook GetPreferences problem: when an extension adds a new pref tab "xyz", <fieldset>...</fieldset> is not generated, <legend>...</legend> is not shown
Hook GetPreferences problem: when an extension adds a new pref tab "xyz", <fi...
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
1.21.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-28 21:44 UTC by T. Gries
Modified: 2013-03-04 22:14 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2013-02-28 21:44:21 UTC
I discovered a problem, here in my Extension:OpenID.

The problem is that the E:OpenID adds a new pref tab ("OpenID"), which works fine since many years, but the <legend>section header texts</legend> are not shown, and the skin looks as if the user skin is fully ignored.

I never reported this, because I did not notice the effect until today.

The effect (no <legend> texts shown) can be seen live in

http://openid-wiki.instance-proxy.wmflabs.org/wiki/Special:Preferences#mw-prefsection-openid

when you compare this pref tab with one of the other pref tabs.

I have no idea how this can be solved. 

For me it looks as a 

+ bug in the core

which effects extensions in loosing skin or context in their new section(s)

when the extension 

+ uses Hook:GetPreferences ; and 
+ adds a new section e.g. "OpenID"
Comment 1 T. Gries 2013-03-01 01:07:38 UTC
Now I found that <fieldset>...</fieldset> tags are not set aroung the sub sections.
Comment 2 T. Gries 2013-03-04 07:47:35 UTC
Solution given by grunny:

If you want the fieldset to appear, I believe you just need to change
all the 'section' => 'openid', in the 

+ preference arrays to 'section' => 'openid/openid', 

and then it will use the prefs-openid message,
which you have already defined, as the section text in the fieldset
legend.

Cheers,
grunny

see discussion thread http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/67930
Comment 3 T. Gries 2013-03-04 22:14:57 UTC
fixed in https://gerrit.wikimedia.org/r/#/c/52154/

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links