Last modified: 2013-03-13 01:55:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47590, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45590 - VisualEditor: 'generated' property should not be preserved when unwrapping
VisualEditor: 'generated' property should not be preserved when unwrapping
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-03-18
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-28 22:32 UTC by Roan Kattouw
Modified: 2013-03-13 01:55 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2013-02-28 22:32:02 UTC
When we unwrap lists, we currently preserve the internal 'generated' property on paragraphs inside those lists, but we really shouldn't. The fact that we don't currently clear this when unwrapping results in the following serious bug:

1. Create a page with the following content
Foo
Bar
* Baz
* Quux
* Whee
Yay
2. Open the page in VE
3. Select across the three list items and click the list button to unlist them
4. VE now shows five paragraphs
5. Click "Review and save" and observe the diff.

Expected diff: the asterisk and space before "Baz", "Quux" and "Whee" are removed.

Actual diff: the second line becomes "BarBazQuuxWhee", followed by three blank lines, then "Yay".

This happens because the converter unwraps paragraphs with the 'internal': { 'generated': 'wrapper' } property, even if these paragraphs now appear in a different context and even if there are multiple such paragraphs adjacent to each other.
Comment 1 Ed Sanders 2013-03-04 16:30:20 UTC
https://gerrit.wikimedia.org/r/#/c/52046/
Comment 2 James Forrester 2013-03-13 01:55:48 UTC
Code now merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links