Last modified: 2013-03-01 02:02:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47591, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45591 - Inconsistent returns in EchoNotificationController::notify()
Inconsistent returns in EchoNotificationController::notify()
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
master
All All
: Unprioritized trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-28 23:30 UTC by Sam Reed (reedy)
Modified: 2013-03-01 02:02 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2013-02-28 23:30:30 UTC 
In one path false is returned by the code, but a return above it returns nothing. Same for the end of the code.

Either add a return value in the first return and at the end of the function, and as such, update the documentation. Or remove the single return value.

The return value is not used in any current code path
Comment 2 Alex Monk 2013-03-01 02:02:12 UTC 
Merged by Reedy.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links