Last modified: 2014-08-18 06:15:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47594, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45594 - Run PHPUnit code coverage once per day
Run PHPUnit code coverage once per day
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on: 43972
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-01 00:46 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-08-18 06:15 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-03-01 00:46:48 UTC
We could use a code coverage report of mediawiki/core unit tests. That has been a long time request by Chris McMahon.  Asher expressed interest too.

We could just run it once per day. No points in having such a CPU intensive task to be done on each merge.
Comment 1 Sam Reed (reedy) 2013-03-01 01:21:20 UTC
(In reply to comment #0)
> We could use a code coverage report of mediawiki/core unit tests. That has
> been
> a long time request by Chris McMahon.  Asher expressed interest too.
> 
> We could just run it once per day. No points in having such a CPU intensive
> task to be done on each merge.

Seems pretty sensible to me. Could do with a standardised place to view it such as integration.wikimedia.org/codecoverage etc
Comment 2 Antoine "hashar" Musso (WMF) 2013-04-10 07:30:04 UTC
The Jenkins job is http://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/?

The code coverage report is/will be available at:
 https://integration.wikimedia.org/cover/mediawiki-core/master/php/
Comment 3 Antoine "hashar" Musso (WMF) 2013-04-10 07:44:41 UTC
Job currently failing due to:

 PHP Fatal error:  Class 'Services_JSON' not found in /var/lib/jenkins/jobs/mediawiki-core-code-coverage/workspace/tests/phpunit/includes/json/ServicesJsonTest.php on line 21

The workspace need to be wiped before the job is build.
Comment 4 Antoine "hashar" Musso (WMF) 2013-04-10 07:55:53 UTC
https://gerrit.wikimedia.org/r/#/c/58467/ let us wipe the workspace, it is applied to the job with https://gerrit.wikimedia.org/r/#/c/58468/ .
Comment 5 Antoine "hashar" Musso (WMF) 2013-04-10 08:52:34 UTC
PHP is segfaulting, see bug 43972
Comment 6 MWJames 2013-05-10 02:03:28 UTC
Any chance having it configured, so that extensions (such as SMW or Wikibase) can make use of it as well?
Comment 7 Antoine "hashar" Musso (WMF) 2013-05-21 08:42:02 UTC
MWJames : as long as it segfault, that is hopeless :)
Comment 8 Gerrit Notification Bot 2013-10-18 08:58:17 UTC
Change 90509 had a related patch set uploaded by Hashar:
'Cover' section listing code coverage reports

https://gerrit.wikimedia.org/r/90509
Comment 9 Gerrit Notification Bot 2013-10-18 08:58:34 UTC
Change 90509 merged by jenkins-bot:
'Cover' section listing code coverage reports

https://gerrit.wikimedia.org/r/90509
Comment 10 Antoine "hashar" Musso (WMF) 2013-10-18 09:00:17 UTC
PHP still segfaults but it happens very late in PHP execution (during shutdown), so the HTML is actually generated and published at https://integration.wikimedia.org/cover/mediawiki-core/master/php/

The change 90509 above adds a 'Coverage' section on https://integration.wikimedia.org/ which points to the manually maintained list of coverage reports we have:

https://integration.wikimedia.org/cover/


Keeping bug open since the Jenkins job producing the coverage code is always failing due to PHP segfaulting (bug 43972).
Comment 11 Antoine "hashar" Musso (WMF) 2013-12-02 14:14:16 UTC
Bug 43972 tracks the segfaulting issue.  Code coverage is generated daily so we can get rid of this bug.
Comment 12 Kunal Mehta (Legoktm) 2014-08-18 06:15:02 UTC
(In reply to MWJames from comment #6)
> Any chance having it configured, so that extensions (such as SMW or
> Wikibase) can make use of it as well?

I filed bug 69685 for extensions.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links