Last modified: 2014-02-04 17:32:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47604, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45604 - jQuery.fn.eachchange event should be re-factored to use jQuery special events API
jQuery.fn.eachchange event should be re-factored to use jQuery special events...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
: javascript, need-volunteer
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-01 14:18 UTC by Daniel A. R. Werner
Modified: 2014-02-04 17:32 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel A. R. Werner 2013-03-01 14:18:06 UTC
Currently, the 'eachchange' event is implemented as a simple jQuery plugin. It has some advanced architecture allowing it to be used with jQuery.fn.on in some situations, but this is not very reliable, usually one should call jQuery.fn.eachchange instead.

Instead of having this as a simple plugin, it should use the jQuery special event API which I have stumbled upon a while ago. It is documented here:
http://benalman.com/news/2010/03/jquery-special-events/

NOTE: currently the eachchange event logic is in the DataValues extension since it is also used in the valueview widgets. It might move again so I have filed the bug here as some of the Wikidata/Wikibase related extensions are making use of it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links