Last modified: 2013-04-22 16:17:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47621, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45621 - Flip guider in opposite direction if it falls outside the viewport
Flip guider in opposite direction if it falls outside the viewport
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Matthew Flaschen
: patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-01 22:34 UTC by Steven Walling
Modified: 2013-04-22 16:17 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Example of issue (189.89 KB, image/png)
2013-03-01 22:34 UTC, Steven Walling 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Steven Walling 2013-03-01 22:34:05 UTC 
Similar to the issue we ran in to at bug 44635, the single step GettingStarted tour can easily fall outside of your view if you have a browser that is ~1024x768 or smaller. 

We could temporarily solve this problem by repositioning the guider on top, or by moving it automatically, but I think the best solution is to flip these particular  guiders from right to left if they fall outside the viewport.
Comment 1 Steven Walling 2013-03-01 22:34:31 UTC 
Created attachment 11872 [details]
Example of issue
Comment 2 Matthew Flaschen 2013-03-12 01:54:21 UTC 
The change to Guiders is https://gerrit.wikimedia.org/r/#/c/53303/ .  It adds an option to flip guiders horizontally and/or vertically (as needed for a particular guider) when it would otherwise go above the top, left of the left side, or right of the right side.

There is also a utility method for doing the actual flip, which will be reused by the RTL code.
Comment 3 Matthew Flaschen 2013-03-12 02:05:20 UTC 
The change to GuidedTour is https://gerrit.wikimedia.org/r/#/c/53309/
Comment 4 Matthew Flaschen 2013-03-15 06:36:10 UTC 
Both merged
Comment 5 Matthew Flaschen 2013-03-15 06:40:31 UTC 
See bug 46137 for an edge case issue with the implementation.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links