Last modified: 2013-04-16 10:02:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47648, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45648 - AutoCreateCategoryPages not working with importDump.php
AutoCreateCategoryPages not working with importDump.php
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
Uniwiki (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
extension[unmaintained]
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-02 21:24 UTC by Alois
Modified: 2013-04-16 10:02 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Alois 2013-03-02 21:24:00 UTC
I am running Mediawiki 1.18. I use the extension AutoCreateCategoryPages. It works, when I edit and save a page the normnal way. But most of our wiki editing is done by creating XML dump files with an external application, and then loading the new or edited pages into the wiki with importDump.php

Since Mediawiki 1.18, the associated category pages do not created upon such a dump import. It used to work with previous releases, up to Mediawiki 1.17

I would be grateful for help, e.g. a patch to importDump.php or information, whether the feature works with newer releases of Mediawiki.
Comment 1 Sam Reed (reedy) 2013-03-02 22:35:35 UTC
I blame the extension

You're also using an unsupported version of MediaWiki
Comment 2 Alois 2013-03-02 23:04:08 UTC
The extensions sets a hook
$wgHooks['ArticleSaveComplete'][] = array($wgAutoCreateCategoryPagesObject,"UW_AutoCreateCategoryPages_Save");

The hook gets called and the extensions functions properly when I edit and save
a page the normal way, via the wiki.

The hook seems not to get called when I import a page via maintenance/importDump.php

This does not look to me like a fault of the extension, but I suspect a fault in importDump.php and the modules it calls to store a page.

If someones could confirm that the extension works with later versions of Mediawiki + importDump.php, I would be happy to go through the trouble of updating.
Comment 3 Alois 2013-03-06 15:51:50 UTC
I have now upgraded Mediawiki to 1.20.3, the latest stable version.

AutoCreateCategoryPages does not work, as it seems that maintenance/importDump.php does not call the hooks.
Comment 4 Alois 2013-03-06 17:03:45 UTC
I patched includes/WikiPage.php with a dirty hack.

It seems that WikiPage::doEditUpdates() gets called from maintenannce/ImportDump.

As the problem seems to be that wfRunHooks( 'ArticleSaveComplete'...) needs to be called, I added just before the end of function doEditUpdates() these two lines:

wfRunHooks( 'ArticleSaveComplete', array( &$this, &$user, $text, '',
       EDIT_MINOR, null, null, null, $revision, null, false ) );

This seems to solve my problem.
Comment 5 Andre Klapper 2013-04-16 08:53:03 UTC
According to one of its developer (Mark), Uniwiki extensions for MediaWiki are not under active development anymore "and it is safe to declare them obsolete/wontfix."

It is unlikely that there will be any further active development.

Closing this report as WONTFIX as part of Bugzilla Housekeeping and adding the whitespace entry "extension[unmaintained]". Please feel free to reopen this bug report in the future if anyone takes the responsibility for active development again.
Comment 6 Alois 2013-04-16 10:02:49 UTC
The patch given in my comment 4 might still be acted upon, as it secures that the necessary hook get called, independent upon the question whether Univiw extension are under continued development or not.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links