Last modified: 2013-03-13 16:23:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47651, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45651 - Toolbar doesn't change when clicking "edit" on a Claim with a PropertyValue main Snak which uses a data value type which doesn't match the Snak's Property's DataType's data value type
Toolbar doesn't change when clicking "edit" on a Claim with a PropertyValue m...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-02 23:57 UTC by Daniel A. R. Werner
Modified: 2013-03-13 16:23 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel A. R. Werner 2013-03-02 23:57:28 UTC 
The toolbar doesn't change, instead it still says "edit" while everything else seems to work. Also using the ESC key to cancel edit mode does still work. Clicking "edit" again while still in edit mode has no effect.

The reason for this is that when clicking "edit", an error is thrown in jQuery.wikibase.snakview.prototype.isInitialSnak (last line of the function), "can not call mothod 'equals' of null".
Comment 1 Daniel A. R. Werner 2013-03-03 00:03:22 UTC 
See I179c161
Comment 2 Daniel A. R. Werner 2013-03-03 00:03:38 UTC 
Ok, I179c161c8dbf97c2787a0fad0dda99637a8d42a4
Comment 3 Henning 2013-03-11 13:32:03 UTC 
https://gerrit.wikimedia.org/r/#/c/51883/ merged.
Comment 4 abraham.taherivand 2013-03-13 16:23:07 UTC 
Verified in Wikidata demp sprint 35
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links