Last modified: 2013-03-27 16:33:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47673, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45673 - Get "add" button related DOM remnants out of jQuery.wikibase.claimlistview and don't use 'wb-claim' template for "add" button
Get "add" button related DOM remnants out of jQuery.wikibase.claimlistview an...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-03 21:11 UTC by Daniel A. R. Werner
Modified: 2013-03-27 16:33 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel A. R. Werner 2013-03-03 21:11:30 UTC
Even though with bug 44745 being solved, the toolbar went out of the claimlistview widget, the DOM which contains the "add" button is still there. The DOM should probably go and be generated where the "add" button is being generated since that DOM doesn't really belong to the widget. If a list of claims should only be displayed and not editable (e.g. during diff views where we don't display the edit buttons) there is no point in having this piece of DOM.

Also, the jQuery.wikibase.claimlistview is currenlty abusing the 'wb-claim' template for the row which displays that "add" button. This is quite confusing and as a result there is some weird code in claimlistview that has to differentiate whether a row is an actual claim or just that row with the "add" button.
Comment 2 abraham.taherivand 2013-03-27 16:33:00 UTC
Verified in Wikidata demo sprint 35-3

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links