Last modified: 2013-03-08 01:21:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47701, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45701 - VisualEditor: Add static name property to CE nodes
VisualEditor: Add static name property to CE nodes
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Low normal
: VE-deploy-2013-03-18
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-04 14:02 UTC by Ed Sanders
Modified: 2013-03-08 01:21 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2013-03-04 14:02:02 UTC 
DM nodes have a static name property which is used by the nodeRegistry. CE nodes currently have their names written out at least twice. It also creates unnecessary complexity when inheriting CE nodes as the parent constructor cannot be used (as it contains the parent's name hard coded).
Comment 1 Ed Sanders 2013-03-06 22:55:08 UTC 
Fixed with https://gerrit.wikimedia.org/r/#/c/52545/
Comment 2 Gerrit Notification Bot 2013-03-07 23:04:01 UTC 
Related URL: https://gerrit.wikimedia.org/r/52545 (Gerrit Patch-Set: Ibf31de16ab28ad58209c1443cd74f93dda278998/7)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links