Last modified: 2013-03-18 09:22:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47713, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45713 - JSLint not disclosing problems
JSLint not disclosing problems
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-04 18:25 UTC by Niklas Laxström
Modified: 2013-03-18 09:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2013-03-04 18:25:10 UTC 
See https://integration.mediawiki.org/ci/job/mwext-Translate-jslint/1455/console linked from https://gerrit.wikimedia.org/r/#/c/52047/

Makes it pretty hard to fix the issues.
Comment 1 Antoine "hashar" Musso (WMF) 2013-03-04 19:09:07 UTC 
I agree this is not perfect.  JSLint logs its output to a XML file and does not offer an option to also log on stdout.  So one has to click the 'Checkstyle Warnings' link on the left : https://integration.mediawiki.org/ci/job/mwext-Translate-jslint/1455/checkstyleResult/?

Ideally we should:
- log errors to the console
- output a link to 'Checkstyle Warnings' in the console log
- change the URL in the message reported back to Jenkins
Comment 2 Antoine "hashar" Musso (WMF) 2013-03-04 19:36:38 UTC 
I have tweaked Zuul to display the checkstyleURL instead of the console:

 https://gerrit.wikimedia.org/r/52076
Comment 3 Antoine "hashar" Musso (WMF) 2013-03-04 19:41:07 UTC 
I have deployed above change in production, that is probably fixing this enhancement request.  Let me know what you think about it and just resolve the bug if that is a works for you :-]
Comment 4 Krinkle 2013-03-18 09:22:44 UTC 
(In reply to comment #1)
> [..] click the 'Checkstyle Warnings' link on the left:
> https://integration.mediawiki.org/ci/job/mwext-Translate-jslint/1455/
> checkstyleResult/?
> 

In particular the "Details" tab is what you'll want to look at.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links