Last modified: 2013-06-26 03:20:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47780, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 45780 - Gerrit mangles Wikipedia permalinks with anchor


Summary:	Gerrit mangles Wikipedia permalinks with anchor

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	Git/Gerrit (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Normal major with 1 vote (vote)
Target Milestone:	---
Assigned To:	christian

URL:	https://gerrit.wikimedia.org/r/#/c/52...
Whiteboard:
Keywords:	upstream

Duplicates:	47324 (view as bug list)
Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-03-06 16:17 UTC by Raimond Spekking
Modified:	2013-06-26 03:20 UTC (History)
CC List:	9 users (show)

See Also:	http://code.google.com/p/gerrit/issues/detail?id=1451 38103
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2013-03-06 16:17:33 UTC

See I161dc93c95bc6657352198c04e3d58698344ba77

My permalink 

https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=115044733#Lua_in_weiteren_Wikipedien

is mangled to

115044733#Lua_in_weiteren_Wikipedien" target="_blank">https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=115044733#Lua_in_weiteren_Wikipedien

Gitweb shows the correct URL:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fextensions%2FScribunto.git;a=commit;h=e865a252bde1bf2bd85d571b2a5933fde560ecb8

Comment 1 Marcin Cieślak 2013-03-06 20:08:20 UTC

This looks like a http://code.google.com/p/gerrit/issues/detail?id=1451 filed upstream some time ago.

Comment 2 Chad H. 2013-04-17 17:52:56 UTC

*** Bug 47324 has been marked as a duplicate of this bug. ***

Comment 3 MZMcBride 2013-04-22 22:02:51 UTC

Mangling user input isn't a low priority issue.

A workaround here is to use leading zeroes, but this really needs to be addressed. I hit this issue again just now at Gerrit change #54505.

Comment 4 Bawolff (Brian Wolff) 2013-04-23 02:43:09 UTC

High might be an exageration provided there is no security issues. Both bugzilla and the old CR mangle user input in slightly less common ways.

Comment 5 Gerrit Notification Bot 2013-05-18 19:37:08 UTC

Related URL: https://gerrit.wikimedia.org/r/64502 (Gerrit Change I53449559bdcb70146102a7b07bb4be9ae3b11e48)

Comment 6 Ori Livneh 2013-06-25 08:25:00 UTC

This drove me nuts. Thanks Christian for the fix & Andrew for the deploy.

Comment 7 MZMcBride 2013-06-26 03:20:19 UTC

\o/

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links