Last modified: 2013-04-22 16:16:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47803, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45803 - Whitespace between == == headers should be insignificant
Whitespace between == == headers should be insignificant
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.21.x
All All
: Low trivial (vote)
: ---
Assigned To: Bartosz Dziewoński
: newparser
Depends on:
Blocks: 41729
  Show dependency treegraph
 
Reported: 2013-03-06 19:54 UTC by Bartosz Dziewoński
Modified: 2013-04-22 16:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-03-06 19:54:48 UTC
Whitespace withing == == headers should be insignificant.

It shouldn't be, as this makes it harder to use the DoEditSectionLink hook to add more inline elements after or before the heading (they will display slightly differently depending on whether ==Heading== or == Heading == was used).

(This isn't visible when using Tidy, as Wikimedia sites do, as it strips the spaces. It can be seen in the resulting HTML on Tidy-less wikis, though.)
Comment 1 Bartosz Dziewoński 2013-03-06 20:31:42 UTC
I0f2d81dd.
Comment 2 Brion Vibber 2013-03-21 22:43:14 UTC
Hrm, the spaces should be insignificant *in* the HTML output. What exactly are the differences you're seeing?
Comment 3 Bartosz Dziewoński 2013-03-21 22:52:38 UTC
== Headline == and ==Headline== should always yield <h3><span class="mw-headline" id="Headline">Headline</span></h3>, and never <h3><span class="mw-headline" id="Headline"> Headline </span></h3> (note the spaces).

Also see the parser tests changes on the patch for a more precise description :)
Comment 4 Brion Vibber 2013-03-21 22:53:32 UTC
Yeah, but those spaces shouldn't cause any rendering difference... but maybe they do. Meh. :D
Comment 5 Bartosz Dziewoński 2013-03-21 22:58:28 UTC
They will once bug 41729 is fixed. :)
Comment 6 Bartosz Dziewoński 2013-03-21 23:52:49 UTC
Merged by Brion.
Comment 7 Gerrit Notification Bot 2013-04-17 12:37:28 UTC
Related URL: https://gerrit.wikimedia.org/r/59620 (Gerrit Change I6a51e3ee07fe7622b9c708c78563795d7a1118fc)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links