Last modified: 2013-03-28 05:09:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47810, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45810 - [Regression] mw.loader.addEmbeddedCSS causes repaints when changing stylesheets
[Regression] mw.loader.addEmbeddedCSS causes repaints when changing stylesheets
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.18.x
All All
: High major with 1 vote (vote)
: 1.21.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-06 22:37 UTC by Krinkle
Modified: 2013-03-28 05:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-03-06 22:37:19 UTC
By default we should always create a new <style> tag.

Appending text to a <style> tag means the contents have to be re-parsed.

Not by the DOM, but for the stylesheet, since the CSS parser can't continue after it ended (it could be left it an open bracket state etc.)

As a result, the browser may have to do various re-paints which are a significant slowdown.

We originally did this "right", but to address the IE stylesheet limit (bug 31676) we changed it to appending text nodes. We should change it back to the right way and only do this hack for IE <= 9.

Modern browsers shouldn't suffer from it.
Comment 3 Krinkle 2013-03-06 23:01:43 UTC
Addressed by these 2 changes:

* Create new style tags
  I52252e699a518dc1c1327ee598a9e023cc2555e2

* Buffer cssText
  I430fba9998b133a85dd3ac38237dc44b38630a9c
Comment 4 Andre Klapper 2013-03-21 15:11:27 UTC
(In reply to comment #3 by Krinkle)
> Addressed by these 2 changes:

Both patches have been committed - is anything else needed here to resolve this bug report as FIXED?
Comment 5 Krinkle 2013-03-22 02:14:51 UTC
(In reply to comment #4)
> (In reply to comment #3 by Krinkle)
> > Addressed by these 2 changes:
> 
> Both patches have been committed - is anything else needed here to resolve
> this bug report as FIXED?

Waiting for them to be deployed on the cluster for final confirmation when it plays together with extensions, one a big Wikipedia article and on a mobile device.
Comment 6 Krinkle 2013-03-28 05:09:40 UTC
According to Paul Irish this has made a big improvement.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links