Last modified: 2013-10-01 09:37:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47815, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45815 - Don't show comments from 'lottery' articles on the Central Feedback page
Don't show comments from 'lottery' articles on the Central Feedback page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-06 23:45 UTC by Fabrice Florin
Modified: 2013-10-01 09:37 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Fabrice Florin 2013-03-06 23:45:13 UTC
Now that we have switched to an opt-in version of AFT5 on the English Wikipedia, we would like to remove comments from disabled 'lottery' articles from this Central Feedback page:
http://en.wikipedia.org/wiki/Special:ArticleFeedbackv5

Going forward, this page would only show comments from articles which have one of these two categories: ' Category:Article Feedback 5' or 'Category:Article Feedback 5 Additional Articles'.

The intent of this revision is to reduce the number of unmoderated comments on this Central Feedback page, in a manner that is more consistent with this community RfC closure:
http://en.wikipedia.org/wiki/Wikipedia:Requests_for_comment/Article_feedback
Comment 1 Matthias Mullie 2013-03-07 13:40:10 UTC
It's nearly impossible to hide them from the central feedback page when the feedback form is no longer "enabled" on a certain page.
Basically, to know if AFT is enabled on a page, these factors are taken into account:
* is the article whitelisted through a category
* is the article subject to the lottery
* is the article not blacklisted through a category
* is the AFTv5 visibility not reduced on a permission-based level (through page protection)
* is the article part of a namespace where it's not disabled

Incorporating all (or any of) these checks in the query fetching the central feedback page data would greatly decrease performance and scalability of this page.

So we can either:
* completely get rid of any feedback that should no longer be displayed
* or mark all of this remaining feedback "archived"

I would suggest to mark all this feedback as archived and still have it available through the archived filter, regardless of whether or not AFTv5 is currently not enabled on their target pages.

Given that soon the auto-archive script should be deployed:
* all unmoderated feedback will soon be archived (minus the feedback on rather inactive pages, which will survive for a long time)
* useful comments of no-longer disabled feedback will still be visible. I think this makes sense though, even though AFTv5 is no longer enabled on that page, someone thought the feedback was useful and it should not automatically be "archived".

I would suggest to expand the current auto-archive script to make it archive unmoderated feedback immediately if AFTv5 is no longer active on that page (rather than make the feedback survive for several more weeks/months depending on how active that article's feedback submissions are)

--

I hope my explanation does not complicate things too much. In short:
* I'd just let auto-archive "get rid" (= archive) of all currently unmoderated feedback for those pages,
* By adding to that current cronjob an additional check to see if the AFT is still active on that page.
OK?
Comment 2 Fabrice Florin 2013-03-07 17:22:46 UTC
Thank you, Matthias, for your clear and detailed explanation. Much appreciated!

Your recommendation to rely on the auto-archive script for this proposal makes very good sense to me. It effectively addresses the intent of this request, which was to reduce the number of unreviewed comments over time. With that in mind, I don't think the cron job is even needed at this time.

You also make a very good point that comments that were featured or marked as useful should not be removed and this process makes this possible. Regarding that point, could the feedback link appear on articles that have useful comments, even if they don't have a category?
Comment 3 Andre Klapper 2013-04-16 10:28:25 UTC
Is this still highest priority, compared to the other AFTv5 tickets (bug 42057, bug 43421)? Asking as there's been no changes for six weeks here.

Matthias: Could you answer Fabrice's comment 2, please?
Comment 4 Matthias Mullie 2013-04-16 10:50:29 UTC
Fabrice: Just to be sure I correctly understood it:
The link to the feedback page should be displayed on the article page & the talk page if there still is unreviewed feedback, regardless of whether or not AFTv5 is enabled for that page, at that point?
Yes, I can do that.

I'm more concerned about how the community might react to this, though. I think it makes sense to have to moderate all remaining feedback (after all, the tool was at some point on, so feedback was sollicited), but I think if they remove the category (or otherwise remove AFT from a page) they might no longer desire any obvious links to the feedback page?
Comment 5 Fabrice Florin 2013-04-16 18:46:20 UTC
Thanks for bringing up these questions again, Andre and Matthias!

In coming days, we plan to finalize our settings regarding links to the feedback page from either the talk page or the article page, with the help of our designer Pau Giner and community members. 

The rationale for this feature is as follows:
* inform editors when there is new or useful feedback about their articles
* give them a quick way to view comments on the feedback page
* let them know if there is useful feedback on the high-traffic article page
* let them know if there is unreviewed feedback on the low-traffic talk page

Based on this rationale, the proposed settings are as follows:
* Article page: Show feedback link if there are featured comments
* Talk page: Show feedback link if there are featured or unreviewed/unarchived comments

The last version of our feature requirements for the article page link is here:
http://www.mediawiki.org/wiki/Article_feedback/Version_5/Feature_Requirements#Feedback_link_on_article_pages

We will discuss these settings in coming days and confirm them shortly -- or propose revised settings, as needed. If we do, that feature requirement will be updated based on our discussion.

Andre, this remains a high priority ticket, because of the prominence of these links, which appear at the top of the article and talk pages. For that reason, I have kept the priority high. Thanks for your understanding.
Comment 6 Matthias Mullie 2013-04-30 12:13:50 UTC
As I last understood it:
* on article pages, the link to the feedback page should only be displayed if AFTv5 is enabled on that page AND if there actually is feedback.
* on talk pages, the link to the feedback page should be displayed is there is feedback, regardless of whether AFTv5 is enabled on the article page or not.

This is how it's currently implemented in https://gerrit.wikimedia.org/r/#/c/35168/

If my understanding is inaccurate, please correct me ;)
Comment 7 Diederik van Liere 2013-10-01 03:18:49 UTC
Can this bug be closed as the patch has been merged?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links