Last modified: 2013-03-21 18:29:36 UTC
Created attachment 11891 [details] shows pixel glitches The arrow that GuidedTour sometimes draws on guiders has some pixel glitches. In the attachment you can see obvious pixels below the arrow tip , and I think a faint darkening above the arrow. I think this occurs because CSS "sprites" the arrow heads from the png modules/ext.guidedTour.arrows.png[1] , and in this the pixels from the shadow around one arrowhead bleed into the crop rectangle of the nearby arrowhead. The fix is to remake the png with a bigger gap between each arrowhead so the shadow pixels don't overlap bounding rectangles, then adjust the CSS. [1] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/GuidedTour.git;a=blob;f=modules/ext.guidedTour.arrows.png;
There is no need to use sprites here, especially if it's causing problems. ResourceLoader instead lets use a separate image for each arrow, all of which will be embedded into the CSS as data URLs (in modern browsers, but there is a working fallback for older ones).
I agree that sprites made this a lot more troublesome, especially since we're drawing shadows around the guiders. I wonder if it's better to just do raw shapes and draw the shadows via CSS. I'll play around with that a little.
I discovered Guiders actually has a _arrowSize field, which we may need to update.
Fix here: https://gerrit.wikimedia.org/r/#/c/55100/ Using CSS to shape our arrows would reduce browser support, so sprites will remain for now. We can tackle _arrowSize in another bug.
Merged.
