Last modified: 2013-04-22 16:14:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47846, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45846 - PHP fatal error when saving banner edits in Special:NoticeTemplate
PHP fatal error when saving banner edits in Special:NoticeTemplate
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Matt Walker
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-07 15:34 UTC by Tilman Bayer
Modified: 2013-04-22 16:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
PHP fatal error on Special:NoticeTemplate (2013-03-07) (144.03 KB, image/png)
2013-03-07 15:34 UTC, Tilman Bayer 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Tilman Bayer 2013-03-07 15:34:01 UTC 
Created attachment 11892 [details]
PHP fatal error on Special:NoticeTemplate (2013-03-07)

Editing a banner (https://meta.wikimedia.org/w/index.php?title=Special:NoticeTemplate/view&template=FDCpropreview20031 ) and clicking "Save banner" resulted in a "Wikimedia Foundation error" page with the following error message:

"PHP fatal error in /usr/local/apache/common-local/php-1.21wmf11/extensions/CentralNotice/special/SpecialNoticeTemplate.php line 919: 
Call to a member function logBannerChange() on a non-object"

Reproduced it in a second edit to the same banner. Both edits saved fine (e.g. https://meta.wikimedia.org/w/index.php?diff=prev&oldid=5304256 ).
Comment 1 Platonides 2013-03-07 15:37:45 UTC 
That's the first time $bannerObj is used, so it's obviously a non-object!
Comment 2 Platonides 2013-03-07 15:39:54 UTC 
Introduced by https://gerrit.wikimedia.org/r/50768, assigning to Matt Walker
Comment 3 Matt Walker 2013-03-07 18:31:20 UTC 
Gah! I thought I fixed this... oh well; here's the patch: https://gerrit.wikimedia.org/r/52639
Comment 4 Matt Walker 2013-03-07 19:18:55 UTC 
Pushed to cluster.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links