Last modified: 2013-03-20 17:18:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47904, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 45904 - ReferencedEntitiesFinder::findClaimLinks does not find items used in Snaks with deleted property with data type item
ReferencedEntitiesFinder::findClaimLinks does not find items used in Snaks wi...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-03-08 16:36 UTC by tobias.gritschacher
Modified: 2013-03-20 17:18 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description tobias.gritschacher 2013-03-08 16:36:39 UTC 
This is a bug in the handling of deleted properties in the UI. If the property was of type "item", the UI will also show the referenced item as "Deleted item" also if it still exists. The correct behavior would be to just show the property as "Deleted property" and show the label of the referenced item as usual.
Comment 1 Daniel A. R. Werner 2013-03-15 13:40:56 UTC 
Try this in your JS console:

> $.evalJSON( mw.config.get( 'wbUsedEntities' ) )

This will not include the item used in the Snak using the deleted property. This is bad and a backend issue: The ReferencedEntitiesFinder::findClaimLinks does not (anymore?) find the item used in the Snak with the deleted property.
Also see EntityView::registerJsConfigVars, line 745:

$usedEntityIds = $refFinder->findClaimLinks( $entity->getClaims() );
Comment 2 Daniel A. R. Werner 2013-03-15 15:45:59 UTC 
See I3bb49eca1f20960a55cfdbd83599eb21d5d07903 for a fix.
Comment 3 abraham.taherivand 2013-03-20 17:18:59 UTC 
Verified in Wikidata demo sprint 35-2
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links